[GitHub] [hive] pgaref commented on a change in pull request #1161: HIVE-23638: Spotbugs issues in hive-common

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #1161:
URL: https://github.com/apache/hive/pull/1161#discussion_r451487709



##########
File path: common/src/java/org/apache/hadoop/hive/common/FileUtils.java
##########
@@ -926,8 +925,7 @@ public static File createLocalDirsTempFile(Configuration conf, String prefix, St
    * delete a temporary file and remove it from delete-on-exit hook.
    */
   public static boolean deleteTmpFile(File tempFile) {
-    if (tempFile != null) {
-      tempFile.delete();
+    if (tempFile != null && tempFile.delete()) {

Review comment:
       Good catch, fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org