[GitHub] [zeppelin] zjffdu commented on a change in pull request #3718: [ZEPPELIN-4727] Fix HDFS Credentials storage

[GitBox <gi...@apache.org>]

zjffdu commented on a change in pull request #3718: [ZEPPELIN-4727] Fix HDFS Credentials storage 
URL: https://github.com/apache/zeppelin/pull/3718#discussion_r405348132
 
 

 ##########
 File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Credentials.java
 ##########
 @@ -18,60 +18,53 @@
 package org.apache.zeppelin.user;
 
 
-import com.google.gson.Gson;
-import com.google.gson.GsonBuilder;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import java.io.BufferedReader;
-import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileOutputStream;
 import java.io.IOException;
-import java.io.InputStreamReader;
-import java.io.OutputStreamWriter;
-import java.nio.file.Files;
-import java.nio.file.attribute.PosixFilePermission;
-import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.Map;
-import java.util.Set;
 
-import static java.nio.file.attribute.PosixFilePermission.OWNER_READ;
-import static java.nio.file.attribute.PosixFilePermission.OWNER_WRITE;
+import org.apache.zeppelin.conf.ZeppelinConfiguration;
+import org.apache.zeppelin.storage.ConfigStorage;
+import org.codehaus.plexus.util.StringUtils;
 
 Review comment:
   It's better to use StringUtils of commons-lang3 which is zeppelin use

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services