You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2023/03/20 04:13:38 UTC

[GitHub] [incubator-pekko] He-Pin created a discussion: Make BroadcastHub only pull when atleast one Consumer attached to it?

GitHub user He-Pin created a discussion: Make BroadcastHub only pull when atleast one Consumer attached to it?

Refs: https://github.com/akka/akka/issues/28327

I just make a PR in akka/akka, which added a `startAfterNrOfConsumers` to `BroadcastHub`. And surely I will send the PR to pekko too.

I think we should make the current `BroadcastHub.sink[T]` with `BroadcastHub.sink[T] = BroadcastHub.sink(startAfterNrOfConsumers = 1, defaultBufferSize)` in pekko by default, which is `0` now.

GitHub link: https://github.com/apache/incubator-pekko/discussions/255

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko] He-Pin edited a discussion: Make BroadcastHub only start pulling after atleast one Consumer attached to it?

Posted by GitBox <gi...@apache.org>.
GitHub user He-Pin edited a discussion: Make BroadcastHub only start pulling after atleast one Consumer attached to it?

Refs: https://github.com/akka/akka/issues/28327

I just made a PR in akka/akka, which added a `startAfterNrOfConsumers` to `BroadcastHub`. And surely I will send the PR to pekko too.

I think we should make the current `BroadcastHub.sink[T]` with `BroadcastHub.sink[T] = BroadcastHub.sink(startAfterNrOfConsumers = 1, defaultBufferSize)` in pekko by default, which is `0` now.

GitHub link: https://github.com/apache/incubator-pekko/discussions/255

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko] He-Pin edited a discussion: Make BroadcastHub only pull when atleast one Consumer attached to it?

Posted by GitBox <gi...@apache.org>.
GitHub user He-Pin edited a discussion: Make BroadcastHub only pull when atleast one Consumer attached to it?

Refs: https://github.com/akka/akka/issues/28327

I just made a PR in akka/akka, which added a `startAfterNrOfConsumers` to `BroadcastHub`. And surely I will send the PR to pekko too.

I think we should make the current `BroadcastHub.sink[T]` with `BroadcastHub.sink[T] = BroadcastHub.sink(startAfterNrOfConsumers = 1, defaultBufferSize)` in pekko by default, which is `0` now.

GitHub link: https://github.com/apache/incubator-pekko/discussions/255

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko] He-Pin edited a discussion: Make BroadcastHub only start pull when atleast one Consumer attached to it?

Posted by GitBox <gi...@apache.org>.
GitHub user He-Pin edited a discussion: Make BroadcastHub only start pull when atleast one Consumer attached to it?

Refs: https://github.com/akka/akka/issues/28327

I just made a PR in akka/akka, which added a `startAfterNrOfConsumers` to `BroadcastHub`. And surely I will send the PR to pekko too.

I think we should make the current `BroadcastHub.sink[T]` with `BroadcastHub.sink[T] = BroadcastHub.sink(startAfterNrOfConsumers = 1, defaultBufferSize)` in pekko by default, which is `0` now.

GitHub link: https://github.com/apache/incubator-pekko/discussions/255

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko] He-Pin added a comment to the discussion: Make BroadcastHub only start pulling after atleast one Consumer attached to it?

Posted by GitBox <gi...@apache.org>.
GitHub user He-Pin added a comment to the discussion: Make BroadcastHub only start pulling after atleast one Consumer attached to it?

I start the discussion in the email list, close now

GitHub link: https://github.com/apache/incubator-pekko/discussions/255#discussioncomment-5408519

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org