You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:07:52 UTC
[GitHub] [apisix] spacewander opened a new pull request #4947: feat(admin): return stream plugin info
spacewander opened a new pull request #4947:
URL: https://github.com/apache/apisix/pull/4947
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4947: feat(admin): return stream plugin info
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4947:
URL: https://github.com/apache/apisix/pull/4947#issuecomment-909200881
See https://github.com/apache/apisix-dashboard/issues/2096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4947: feat(admin): return stream plugin info
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4947:
URL: https://github.com/apache/apisix/pull/4947#discussion_r700681618
##########
File path: docs/zh/latest/admin-api.md
##########
@@ -927,6 +927,7 @@ Content-Type: text/plain
| ----------- | ----------------------------------- | ---------- | ------------- |
| GET | /apisix/admin/plugins/list | 无 | 获取资源列表 |
| GET | /apisix/admin/plugins/{plugin_name} | 无 | 获取资源 |
+| GET | /apisix/admin/plugins?all=true | 无 | 获取所有插件的所有属性|
Review comment:
Look like it is an issue with the en docs. I can confirm these two APIs exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] liuxiran commented on a change in pull request #4947: feat(admin): return stream plugin info
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #4947:
URL: https://github.com/apache/apisix/pull/4947#discussion_r700393218
##########
File path: docs/zh/latest/admin-api.md
##########
@@ -927,6 +927,7 @@ Content-Type: text/plain
| ----------- | ----------------------------------- | ---------- | ------------- |
| GET | /apisix/admin/plugins/list | 无 | 获取资源列表 |
| GET | /apisix/admin/plugins/{plugin_name} | 无 | 获取资源 |
+| GET | /apisix/admin/plugins?all=true | 无 | 获取所有插件的所有属性|
Review comment:
I noticed that we do not have `/apisix/admin/plugins/list ` and `/apisix/admin/plugins/{plugin_name} ` in our en docs, and it seems that we don't have this two APIs, so do we need to remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4947: feat(admin): return stream plugin info
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4947:
URL: https://github.com/apache/apisix/pull/4947#issuecomment-909200881
See https://github.com/apache/apisix-dashboard/issues/2096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4947: feat(admin): return stream plugin info
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4947:
URL: https://github.com/apache/apisix/pull/4947#discussion_r700682749
##########
File path: docs/zh/latest/admin-api.md
##########
@@ -927,6 +927,7 @@ Content-Type: text/plain
| ----------- | ----------------------------------- | ---------- | ------------- |
| GET | /apisix/admin/plugins/list | 无 | 获取资源列表 |
| GET | /apisix/admin/plugins/{plugin_name} | 无 | 获取资源 |
+| GET | /apisix/admin/plugins?all=true | 无 | 获取所有插件的所有属性|
Review comment:
We have them: https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#request-methods-8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4947: feat(admin): return stream plugin info
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4947:
URL: https://github.com/apache/apisix/pull/4947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4947: feat(admin): return stream plugin info
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4947:
URL: https://github.com/apache/apisix/pull/4947#issuecomment-909200881
See https://github.com/apache/apisix-dashboard/issues/2096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org