You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/24 04:24:05 UTC

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #10718: [QNN] Add per-channel quantization to add/subtract/multiply

AndrewZhaoLuo commented on a change in pull request #10718:
URL: https://github.com/apache/tvm/pull/10718#discussion_r833546819



##########
File path: python/tvm/relay/qnn/op/qnn.py
##########
@@ -623,6 +632,12 @@ def add(
     output_zero_point: relay.Expr
        The zero point of output quantized expr.
 
+    lhs_axis: int
+        The channel axis for lhs quantization. Default value is -1.

Review comment:
       Might want to add "which corresponds to the last axis."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org