You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "mattp5657 (via GitHub)" <gi...@apache.org> on 2026/09/12 18:27:09 UTC
[PR] fix(connectors): meilisearch_sink URL scheme check is case-sensitive [iggy]
mattp5657 opened a new pull request, #4158:
URL: https://github.com/apache/iggy/pull/4158
## Which issue does this PR address?
Closes #4157
## What changed?
`normalize_host` detected the URL scheme via a literal `starts_with("http://")`/`starts_with("https://")` check. An uppercase or mixed-case scheme like `HTTPS://host` matched neither literal, fell through to the "no scheme" branch, and got `http://` prepended, producing `http://HTTPS://host`, which parses as `scheme="http"`, `host="https"`, silently connecting to the wrong host over plaintext.
Scheme detection is now case-insensitive (`eq_ignore_ascii_case` on the split-off scheme), matching `opensearch_sink`'s existing pattern. An unsupported scheme (e.g. `ftp://`) is now also rejected outright instead of being silently mangled the same way.
## Local Execution
- Passed
- Pre-commit hooks ran
## AI Usage
Claude was used in creating this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(connectors): meilisearch_sink URL scheme check is case-sensitive [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #4158:
URL: https://github.com/apache/iggy/pull/4158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(connectors): meilisearch_sink URL scheme check is case-sensitive [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4158:
URL: https://github.com/apache/iggy/pull/4158#issuecomment-5647877799
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4158?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `59.37500%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 30.86%. Comparing base ([`dc2b382`](https://app.codecov.io/gh/apache/iggy/commit/dc2b382097ed7fb6cfeb8a31fed0fbc74af4433e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee8b89b`](https://app.codecov.io/gh/apache/iggy/commit/ee8b89bb4770019533a76708f3c247291280bd99?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 10 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4158?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [core/connectors/sinks/meilisearch\_sink/src/lib.rs](https://app.codecov.io/gh/apache/iggy/pull/4158?src=pr&el=tree&filepath=core%2Fconnectors%2Fsinks%2Fmeilisearch_sink%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3NpbmtzL21laWxpc2VhcmNoX3Npbmsvc3JjL2xpYi5ycw==) | 59.37% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4158 +/- ##
=============================================
- Coverage 86.38% 30.86% -55.53%
Complexity 1455 1455
=============================================
Files 1259 1266 +7
Lines 205992 172457 -33535
Branches 171193 137658 -33535
=============================================
- Hits 177955 53235 -124720
- Misses 23597 117204 +93607
+ Partials 4440 2018 -2422
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/4158/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4158/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.84% <59.37%> (-70.49%)` | :arrow_down: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4158/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.58% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4158/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.97% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4158/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.34% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4158/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.65% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4158/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.17% <ø> (ø)` | |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4158/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.40% <ø> (ø)` | |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4158?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/connectors/sinks/meilisearch\_sink/src/lib.rs](https://app.codecov.io/gh/apache/iggy/pull/4158?src=pr&el=tree&filepath=core%2Fconnectors%2Fsinks%2Fmeilisearch_sink%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25uZWN0b3JzL3NpbmtzL21laWxpc2VhcmNoX3Npbmsvc3JjL2xpYi5ycw==) | `67.64% <59.37%> (-5.63%)` | :arrow_down: |
... and [665 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4158/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(connectors): meilisearch_sink URL scheme check is case-sensitive [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4158:
URL: https://github.com/apache/iggy/pull/4158#issuecomment-5647834461
<!-- iggy-pr-triage-welcome -->
Thanks for the PR. It is labeled `S-waiting-on-review` and queued for review.
Slash commands (own line, regular comment) move it around the queue:
- `/ready` - back to `S-waiting-on-review` after addressing feedback
- `/author` - flip to `S-waiting-on-author` while you finish changes
- `/request-review @user-or-team` - request a reviewer
- `/pin` - exempt the PR from the stale bot, `/unpin` to undo
See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md#pr-triage-commands) for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org