You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Sebastian Schelter (JIRA)" <ji...@apache.org> on 2011/02/03 21:49:30 UTC

[jira] Created: (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Parallelize non-distributed ALSWRFactorizer
-------------------------------------------

                 Key: MAHOUT-606
                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
             Project: Mahout
          Issue Type: Improvement
          Components: Collaborative Filtering
            Reporter: Sebastian Schelter
            Assignee: Sean Owen
         Attachments: MAHOUT-606.patch

Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Posted by "Sebastian Schelter (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165959#comment-13165959 ] 

Sebastian Schelter edited comment on MAHOUT-606 at 12/9/11 9:02 AM:
--------------------------------------------------------------------

Here's how to create patches with SVN http://ariejan.net/2007/07/03/how-to-create-and-apply-a-patch-with-subversion

I think we should rather find out why the iterator has a problem. Would you care to dig a little deeper? And we should open a new JIRA ticket for the bug hunt, could you do this?
                
      was (Author: ssc):
    Here's how to create patches with SVN http://ariejan.net/2007/07/03/how-to-create-and-apply-a-patch-with-subversion

I think we should rather find out why the iterator has a problem. Would you care to dig a little deeper? 
                  
> Parallelize non-distributed ALSWRFactorizer
> -------------------------------------------
>
>                 Key: MAHOUT-606
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sebastian Schelter
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: ALSWRFactorizer.java, MAHOUT-606.patch
>
>
> Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebastian Schelter updated MAHOUT-606:
--------------------------------------

        Fix Version/s: 0.5
    Affects Version/s: 0.5
               Status: Patch Available  (was: Open)

> Parallelize non-distributed ALSWRFactorizer
> -------------------------------------------
>
>                 Key: MAHOUT-606
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sebastian Schelter
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: MAHOUT-606.patch
>
>
> Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Posted by "Georgi Stanev (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165967#comment-13165967 ] 

Georgi Stanev commented on MAHOUT-606:
--------------------------------------

Thanks for the link. Unfortunately I don't have svn installed on my pc and I'm not allowed to install it... What ever...
At this point I don't have the time to go deeper into this problem.
When I get some more time, I'll do this.
                
> Parallelize non-distributed ALSWRFactorizer
> -------------------------------------------
>
>                 Key: MAHOUT-606
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sebastian Schelter
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: ALSWRFactorizer.java, MAHOUT-606.patch
>
>
> Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Posted by "Sebastian Schelter (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165303#comment-13165303 ] 

Sebastian Schelter commented on MAHOUT-606:
-------------------------------------------

Can you provide a patch?
                
> Parallelize non-distributed ALSWRFactorizer
> -------------------------------------------
>
>                 Key: MAHOUT-606
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sebastian Schelter
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: MAHOUT-606.patch
>
>
> Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994503#comment-12994503 ] 

Hudson commented on MAHOUT-606:
-------------------------------

Integrated in Mahout-Quality #626 (See [https://hudson.apache.org/hudson/job/Mahout-Quality/626/])
    MAHOUT-606 Parallelize non-distributed ALSWRFactorizer


> Parallelize non-distributed ALSWRFactorizer
> -------------------------------------------
>
>                 Key: MAHOUT-606
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sebastian Schelter
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: MAHOUT-606.patch
>
>
> Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebastian Schelter updated MAHOUT-606:
--------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

> Parallelize non-distributed ALSWRFactorizer
> -------------------------------------------
>
>                 Key: MAHOUT-606
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sebastian Schelter
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: MAHOUT-606.patch
>
>
> Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Posted by "Georgi Stanev (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Georgi Stanev updated MAHOUT-606:
---------------------------------

    Attachment: ALSWRFactorizer.java

I attached the modified file.
Don't really know how to provide a patch :(
                
> Parallelize non-distributed ALSWRFactorizer
> -------------------------------------------
>
>                 Key: MAHOUT-606
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sebastian Schelter
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: ALSWRFactorizer.java, MAHOUT-606.patch
>
>
> Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Posted by "Sebastian Schelter (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165959#comment-13165959 ] 

Sebastian Schelter commented on MAHOUT-606:
-------------------------------------------

Here's how to create patches with SVN http://ariejan.net/2007/07/03/how-to-create-and-apply-a-patch-with-subversion

I think we should rather find out why the iterator has a problem. Would you care to dig a little deeper? 
                
> Parallelize non-distributed ALSWRFactorizer
> -------------------------------------------
>
>                 Key: MAHOUT-606
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sebastian Schelter
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: ALSWRFactorizer.java, MAHOUT-606.patch
>
>
> Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994287#comment-12994287 ] 

Sean Owen commented on MAHOUT-606:
----------------------------------

Looks fine to me at a glance. You know this code well so I bet it's fine, especially as you have tests. I can look at it in detail after it's committed to see if there are any minor things to suggest but that shouldn't hold you up.

> Parallelize non-distributed ALSWRFactorizer
> -------------------------------------------
>
>                 Key: MAHOUT-606
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sebastian Schelter
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: MAHOUT-606.patch
>
>
> Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAHOUT-606) Parallelize non-distributed ALSWRFactorizer

Posted by "Georgi Stanev (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165233#comment-13165233 ] 

Georgi Stanev commented on MAHOUT-606:
--------------------------------------

Got a little problem with that patch.

Got an assertion in the solver at solve on line 158 that both vector lengths are unequal. What did helped is instead building the featureVectors (line 156) in a while with iterator, build it in foreach (like line 194) using the PreferenceArray (line 149). Should be the same but there is obviously a problem with the iterator.

Just want to share those thoughts for anyone who have problems with this.
                
> Parallelize non-distributed ALSWRFactorizer
> -------------------------------------------
>
>                 Key: MAHOUT-606
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-606
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sebastian Schelter
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: MAHOUT-606.patch
>
>
> Add multithreading to ALSWRFactorizer so that all available cores are used for the computation of the factorization

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira