You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2021/02/06 10:05:17 UTC
[GitHub] [unomi] liatiusim opened a new pull request #246: create a method for match calculation
liatiusim opened a new pull request #246:
URL: https://github.com/apache/unomi/pull/246
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber merged pull request #246: UNOMI-461: create a method for match calculation
Posted by GitBox <gi...@apache.org>.
sergehuber merged pull request #246:
URL: https://github.com/apache/unomi/pull/246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on pull request #246: UNOMI-461: create a method for match calculation
Posted by GitBox <gi...@apache.org>.
sergehuber commented on pull request #246:
URL: https://github.com/apache/unomi/pull/246#issuecomment-824591390
Hello @liatiusim . After reviewing this once more I've decided to include it for the 1.5.5 release, you can add an integration test in a separate PR. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] liatiusim commented on pull request #246: UNOMI-461: create a method for match calculation
Posted by GitBox <gi...@apache.org>.
liatiusim commented on pull request #246:
URL: https://github.com/apache/unomi/pull/246#issuecomment-817930830
Hey Serge, sorry for the late response.
Iv'e added a Jira task and updated the title of this PR. I'll add the itest soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on pull request #246: UNOMI-461: create a method for match calculation
Posted by GitBox <gi...@apache.org>.
sergehuber commented on pull request #246:
URL: https://github.com/apache/unomi/pull/246#issuecomment-822253778
@liatiusim I'll wait until you commit the integration test to review this in the final state. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on pull request #246: UNOMI-461: create a method for match calculation
Posted by GitBox <gi...@apache.org>.
sergehuber commented on pull request #246:
URL: https://github.com/apache/unomi/pull/246#issuecomment-821101462
Thanks @liatiusim !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on pull request #246: create a method for match calculation
Posted by GitBox <gi...@apache.org>.
sergehuber commented on pull request #246:
URL: https://github.com/apache/unomi/pull/246#issuecomment-795546545
@liatiusim did you see the previous question?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on pull request #246: create a method for match calculation
Posted by GitBox <gi...@apache.org>.
sergehuber commented on pull request #246:
URL: https://github.com/apache/unomi/pull/246#issuecomment-817774987
@liatiusim could you please update this ticket and create the JIRA and possibly an integration test ? If nothing is done I'll have to close this PR without merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org