You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2015/06/02 06:50:17 UTC

[jira] [Comment Edited] (FC-109) break core package cycles

    [ https://issues.apache.org/jira/browse/FC-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568515#comment-14568515 ] 

Emmanuel Lecharny edited comment on FC-109 at 6/2/15 4:49 AM:
--------------------------------------------------------------

Sounds like the right thing to do.

Can you confirm that those classes are going to be moved in the 'model' package ? :

* Address
* Administrator
* AdminRole
* AdminRoleRelationship
* AdminUtil
* AuthZ
* Bind
* FortEntity
* Graphable
* Hier
* Mod
* OrgUnit
* OrgUnitAnt
* OrgUnitRelationship
* PermGrant
* Permission
* PermObj
* Props
* PwMessage
* PwPolicy
* PwPolicyControl
* Relationship
* Role
* RolePerm
* RoleRelationship
* SDSet
* Session
* User
* UserAdminRole
* UserAudit
* UserRole
* Warning

I think there is only two package cycles in this case : 
* the {{UserAdminRole}} class depends on the rbac package {{RoleUtil}} class
* the {{UserRole}} class depends on the rbac package {{RoleUtil}} class

It might be necessary to split the {{RoleUtil}} class into two fragments.


was (Author: elecharny):
Sounds like the right thing to do.

Can you confirm that those classes are going to be moved in the 'model' package ?
:

Address
Administrator
AdminRole
AdminRoleRelationship
AdminUtil
AuthZ
Bind
FortEntity
Graphable
Hier
Mod
OrgUnit
OrgUnitAnt
OrgUnitRelationship
PermGrant
Permission
PermObj
Props
PwMessage
PwPolicy
PwPolicyControl
Relationship
Role
RolePerm
RoleRelationship
SDSet
Session
User
UserAdminRole
UserAudit
UserRole
Warning

I think there is only two package cycles in this case : 
* the {{UserAdminRole}} class depends on the rbac package {{RoleUtil}} class
* the {{UserRole}} class depends on the rbac package {{RoleUtil}} class

It might be necessary to split the {{RoleUtil}} class into two fragments.

> break core package cycles
> -------------------------
>
>                 Key: FC-109
>                 URL: https://issues.apache.org/jira/browse/FC-109
>             Project: FORTRESS
>          Issue Type: Sub-task
>    Affects Versions: 1.0.0-RC41
>            Reporter: Shawn McKinney
>             Fix For: 1.0.0
>
>
> remove the package cycles from the core by moving the entities into a separate package named 'model'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)