You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/04/13 13:13:08 UTC

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #969: transport/cmac: Fix race on LL event write

andrzej-kaczmarek opened a new pull request #969:
URL: https://github.com/apache/mynewt-nimble/pull/969


   HCI commands are processed in LL task context and thus CS/CC events are
   written to mbox in the same context. This can lead to following race:
   - CS/CC is written to mbox
   - interrupt in handled on CMAC *before* command buffer is freed
   - M33 reads CS/CC and writes next command to mbox
   - CMAC reads new command
   
   This triggers an assert in code because we do not have free buffer for
   new command because we were busy handling interrupts and did not free
   it yet.
   
   To fix this we should write and free in critical section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #969: transport/cmac: Fix race on LL event write

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #969:
URL: https://github.com/apache/mynewt-nimble/pull/969#issuecomment-818884031


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #969: transport/cmac: Fix race on LL event write

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged pull request #969:
URL: https://github.com/apache/mynewt-nimble/pull/969


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org