You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/13 07:09:54 UTC
[GitHub] [pulsar-test-infra] tisonkun opened a new issue, #58: Use Docker container action for docbot
tisonkun opened a new issue, #58:
URL: https://github.com/apache/pulsar-test-infra/issues/58
https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action
I don't know why we use composition and leave the [docbot workflow](https://github.com/apache/pulsar/blob/fb0f653eadcf6bf72eb8c8efcc29975da6e21267/.github/workflows/ci-documentbot.yml) checkout source code and setup golang.
We can make the use experience like pulsarbot action.
cc @maxsxu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] tisonkun commented on issue #58: Use Docker container action for docbot
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #58:
URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1225879730
Cool! Then I'll close this issue as won't do.
Although, we can still try to let the docbot action to be used as barely `apache/pulsar-test-infra/docbot@main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] tisonkun commented on issue #58: Use Docker container action for docbot
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #58:
URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1213891090
See also https://github.com/tisonkun/pulsar-test-infra/tree/docker-action for a prototype, the docker image size is 12.9MB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] maxsxu commented on issue #58: Use Docker container action for docbot
Posted by GitBox <gi...@apache.org>.
maxsxu commented on issue #58:
URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1225869732
@tisonkun You have raised a very valuable question. I do curious about the real performance between composite action and docker action. So I did a quick test and the results show that composite action takes only about half the execution time of docker action.
- [Comparison](https://github.com/open-github/pulsar/actions/workflows/ci-documentbot.yml) as shown below:
> <img width="925" alt="image" src="https://user-images.githubusercontent.com/15963141/186450802-7b95a180-6ee5-4f19-8653-697846bbc1de.png">
- [Details of composite action](https://github.com/open-github/pulsar/runs/7995320623?check_suite_focus=true):
> <img width="611" alt="image" src="https://user-images.githubusercontent.com/15963141/186451495-04591dfd-e813-4896-9465-de000309847b.png">
- [Details of docker action:](https://github.com/open-github/pulsar/runs/7997522614?check_suite_focus=true)
> <img width="611" alt="image" src="https://user-images.githubusercontent.com/15963141/186451851-c94ea119-7076-41b7-a129-003a8dc0468d.png">
For short operations like labeling, we need to run our action quickly. So execution speed is the primary requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] tisonkun closed issue #58: Use Docker container action for docbot
Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #58: Use Docker container action for docbot
URL: https://github.com/apache/pulsar-test-infra/issues/58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] maxsxu commented on issue #58: Use Docker container action for docbot
Posted by GitBox <gi...@apache.org>.
maxsxu commented on issue #58:
URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1225889058
> Although, we can still try to let the docbot action to be used as barely `apache/pulsar-test-infra/docbot@main`.
Yes, one thing we can be sure of now is to simplify the current ci-documentbot.yaml workflow file like this https://github.com/open-github/pulsar/blob/master/.github/workflows/ci-documentbot.yml. which is both applicable for whether composite or docker.
This will send PR in both pulsar-test-infra and pulsar repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] maxsxu commented on issue #58: Use Docker container action for docbot
Posted by GitBox <gi...@apache.org>.
maxsxu commented on issue #58:
URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1216403487
The main reason for using composite instead of docker initially was the speed of execution, as the latency to build and retrieve the container.
> I don't know why we use composition and leave the [docbot workflow](https://github.com/apache/pulsar/blob/fb0f653eadcf6bf72eb8c8efcc29975da6e21267/.github/workflows/ci-documentbot.yml) checkout source code and setup golang.
We can also try to put these steps into the composite action itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] michaeljmarshall commented on issue #58: Use Docker container action for docbot
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #58:
URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1214284219
I agree with moving this to a docker action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] tisonkun commented on issue #58: Use Docker container action for docbot
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #58:
URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1219054222
Download an image with 12.9MB may be faster than setting up go environment. We can give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org