You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Luke Cwik (JIRA)" <ji...@apache.org> on 2017/07/26 14:55:00 UTC

[jira] [Assigned] (BEAM-2658) SerializableCoder has higher precedence over ProtoCoder in CoderRegistry#getCoder

     [ https://issues.apache.org/jira/browse/BEAM-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luke Cwik reassigned BEAM-2658:
-------------------------------

    Assignee: Neville Li  (was: Davor Bonaci)

> SerializableCoder has higher precedence over ProtoCoder in CoderRegistry#getCoder
> ---------------------------------------------------------------------------------
>
>                 Key: BEAM-2658
>                 URL: https://issues.apache.org/jira/browse/BEAM-2658
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.0.0
>            Reporter: Neville Li
>            Assignee: Neville Li
>            Priority: Minor
>
> {code}
> import com.google.protobuf.Timestamp;
> import org.apache.beam.sdk.Pipeline;
> import org.apache.beam.sdk.coders.CannotProvideCoderException;
> import org.apache.beam.sdk.coders.Coder;
> import org.apache.beam.sdk.options.PipelineOptions;
> import org.apache.beam.sdk.options.PipelineOptionsFactory;
> public class CoderTest {
>   public static void main(String[] args) throws CannotProvideCoderException {
>     PipelineOptions options = PipelineOptionsFactory.fromArgs(args).create();
>     Pipeline pipeline = Pipeline.create(options);
>     Coder<Timestamp> coder = pipeline.getCoderRegistry().getCoder(Timestamp.class);
>     // class org.apache.beam.sdk.coders.SerializableCoder
>     System.out.println(coder.getClass());
>   }
> }
> {code}
> Right now we're sorting {{CoderProviderRegistrar}}s by canonical name but {{SerializableCoderProvider}} should be added last as a fallback if there're other {{CoderProvider}}s that support the same type.
> {code}
> Set<CoderProviderRegistrar> registrars = Sets.newTreeSet(ObjectsClassComparator.INSTANCE);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)