You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Xiao Meng <xi...@gmail.com> on 2014/10/08 22:39:58 UTC
Review Request 26455: DRILL -1511. C++ Client. Fix compiling issues in
DRILL-1297 patch on clang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26455/
-----------------------------------------------------------
Review request for drill and Parth Chandra.
Bugs: DRILL-1511
https://issues.apache.org/jira/browse/DRILL-1511
Repository: drill-git
Description
-------
- Remove forward enum type declaration (not allowed in C++ 03).
- Add space between `<` and `::` to fix compilation of clang
Diffs
-----
contrib/native/client/src/clientlib/drillClient.cpp db7d5a8
contrib/native/client/src/include/drill/drillClient.hpp f1369ee
Diff: https://reviews.apache.org/r/26455/diff/
Testing
-------
Thanks,
Xiao Meng
Re: Review Request 26455: DRILL -1511. C++ Client. Fix compiling
issues in DRILL-1297 patch on clang
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26455/#review57751
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On Oct. 8, 2014, 8:39 p.m., Xiao Meng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26455/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 8:39 p.m.)
>
>
> Review request for drill and Parth Chandra.
>
>
> Bugs: DRILL-1511
> https://issues.apache.org/jira/browse/DRILL-1511
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> - Remove forward enum type declaration (not allowed in C++ 03).
> - Add space between `<` and `::` to fix compilation of clang
>
>
> Diffs
> -----
>
> contrib/native/client/src/clientlib/drillClient.cpp db7d5a8
> contrib/native/client/src/include/drill/drillClient.hpp f1369ee
>
> Diff: https://reviews.apache.org/r/26455/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xiao Meng
>
>