[GitHub] [accumulo] cshannon commented on a diff in pull request #3246: WIP - Prototype Ranged RFile Reader

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on code in PR #3246:
URL: https://github.com/apache/accumulo/pull/3246#discussion_r1143958571


##########
core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java:
##########
@@ -1553,4 +1565,256 @@ public void setCacheProvider(CacheProvider cacheProvider) {
       reader.setCacheProvider(cacheProvider);
     }
   }
+
+  public static class RangedReader extends HeapIterator implements RFileReader {

Review Comment:
   I will need to look at it more when I have time later this week and test/verify to confirm but I think we should be able to move it outside of RFile. I mostly added it inside the RFile as that was where the other existing Reader was vs some actual need for it to be there. The biggest thing is FencedReader which is used inside of the RangedReader is package scope and any other protected things need to be accessible so if we move it outside the file we need to make sure those things are still visible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org