You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <ol...@apache.org> on 2007/03/07 21:11:44 UTC

[HttpCore] API changes was Re: ConnectingIOReactor.connect() and SessionRequestCallback

On Wed, 2007-03-07 at 20:35 +0530, Asankha C. Perera wrote: 
> Hi Oleg
> > There are provisions in the SessionRequest impl code that ensure
> > SessionRequestCallback will fire even if it is set after completion of
> > the request (successful or unsuccessful). However, since this question
> > pops up fairly regularly, I do have to admit this may be not obvious
> > without actually reading the javadocs. I was hesitant whether I should
> > make connect method take SessionRequestCallback as a parameter, as I
> > generally tend to dislike methods that take more than 3 parameters, but
> > in this case this seems justified. Fix coming.
> >   
> thanks Oleg! Maybe you could have an overloaded method in addition, for 
> those of us who want to pass a SessionRequestCallback as well
> 
> regards
> asankha
> 

Folks,

I have made some API changes to the ConnectingIOReactor interface per
discussion with Asankha. This will require adjustments to client side
code based on HttpCore NIO. I apologize for inconveniences this may
cause you.

Evil Comrade Oleg

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


RE: [HttpCore] API changes was Re: ConnectingIOReactor.connect() andSessionRequestCallback

Posted by Anders Wallgren <an...@electric-cloud.com>.
No problem -- keep up the good work!

anders

-----Original Message-----
From: Oleg Kalnichevski [mailto:olegk@apache.org] 
Sent: Wednesday, March 07, 2007 12:12 PM
To: HttpComponents Project
Subject: [HttpCore] API changes was Re: ConnectingIOReactor.connect()
andSessionRequestCallback

On Wed, 2007-03-07 at 20:35 +0530, Asankha C. Perera wrote: 
> Hi Oleg
> > There are provisions in the SessionRequest impl code that ensure
> > SessionRequestCallback will fire even if it is set after completion
of
> > the request (successful or unsuccessful). However, since this
question
> > pops up fairly regularly, I do have to admit this may be not obvious
> > without actually reading the javadocs. I was hesitant whether I
should
> > make connect method take SessionRequestCallback as a parameter, as I
> > generally tend to dislike methods that take more than 3 parameters,
but
> > in this case this seems justified. Fix coming.
> >   
> thanks Oleg! Maybe you could have an overloaded method in addition,
for 
> those of us who want to pass a SessionRequestCallback as well
> 
> regards
> asankha
> 

Folks,

I have made some API changes to the ConnectingIOReactor interface per
discussion with Asankha. This will require adjustments to client side
code based on HttpCore NIO. I apologize for inconveniences this may
cause you.

Evil Comrade Oleg

> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
httpcomponents-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:
httpcomponents-dev-help@jakarta.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail:
httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail:
httpcomponents-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org