You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@servicecomb.apache.org by "Likun Liu (Jira)" <ji...@apache.org> on 2020/07/13 03:07:00 UTC
[jira] [Closed] (SCB-2038) Rename AbstractRestInvocation and its
class hierarchy to avoid confusion
[ https://issues.apache.org/jira/browse/SCB-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Likun Liu closed SCB-2038.
--------------------------
Resolution: Won't Fix
The part of code is undergoing big refactoring currently, these classes will be deleted eventually, so won't rename them.
> Rename AbstractRestInvocation and its class hierarchy to avoid confusion
> -------------------------------------------------------------------------
>
> Key: SCB-2038
> URL: https://issues.apache.org/jira/browse/SCB-2038
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: Likun Liu
> Assignee: Likun Liu
> Priority: Trivial
> Fix For: java-chassis-2.1.1
>
>
> AbstractRestInvocation class is not an invocation itself, it contains an Invocation field which is the invocation. The responsibilities of AbstractRestInvocation are the preparation, creation, and coordination of the invocation.
>
> The class name is quite confusing and so are the inherited classes of this class. Rename this class hierarchy to Coordinator class will be much clearer in terms of what they do.
>
> The proposed new class names:
>
> AbstractRestInvocation -> AbstractRestInvocationCoordinator
> RestProducerInvocation -> RestProducerInvocationCoordinator
> VertxRestInvocation -> VertxRestInvocationCoordinator
> EdgeInvocation -> EdgeInvocationCoordinator
> RestServletProducerInvocation -> RestServletProducerInvocationCoordinator
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)