You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/17 19:03:00 UTC
[jira] [Commented] (METRON-1158) Build backend for grouping alerts
into meta alerts
[ https://issues.apache.org/jira/browse/METRON-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208177#comment-16208177 ]
ASF GitHub Bot commented on METRON-1158:
----------------------------------------
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/803
Metron-1252: Build ui for grouping alerts into meta alerts
## Contributor Comments
The purpose of the PR is to provide GUI for grouping multiple alerts into a meta alert, the rest api for this is already available via [METRON-1158](https://issues.apache.org/jira/browse/METRON-1158)
The current implementation has following features
- Meta alert can be created from the tree view of alerts
- Meta alerts can be viewed in the table view
- The meta alert has a link icon on the left to denote that it is a meta alert
- The meta alert has a expand/collapse icon to see all the alerts within it
- The meta alert has a cumulative score (more on how this score is calculated is available in the original ticket)
- Support to add/remove an alert to the meta alert from the table view
- Change the state of meta alert
- Add comments to a meta alert
- Option to name a meta alert (This is just a convenience to refer to alerts)
**Limitations**
- Meta alerts cannot be viewed in the tree view
- Adding comments/Status change is restricted to just meta alerts. You cannot perform these actions on alerts contained in meta alert
- A meta alert can contain only 999 alerts
- Delete of the entire meta alert is not supported yet
**Next**
- It will be nice to have a notification when entities are changed in the UI
I noticed that search on GUID was not working before I fixed it in this PR.
E2E tests are incoming I wanted to check if the community has any suggestion on this.
PS: I had to comment one of the test cases since sort by guid is broke. I will raise a ticket for it*
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iraghumitra/incubator-metron METRON-1252
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/803.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #803
----
commit 52d721e50b2136165d89195978d110c3541b046f
Author: iraghumitra <ra...@gmail.com>
Date: 2017-10-17T13:30:36Z
Initial commit for grouping alerts into a meta alert
commit 09747a739db12741f26b0f14acb5073986c3d369
Author: iraghumitra <ra...@gmail.com>
Date: 2017-10-17T16:04:38Z
Disallow comments for a alert in meta alert
commit dba5493d9836047df6411d583b9c12327a524624
Author: iraghumitra <ra...@gmail.com>
Date: 2017-10-17T18:22:18Z
Fixed the existing tests
----
> Build backend for grouping alerts into meta alerts
> --------------------------------------------------
>
> Key: METRON-1158
> URL: https://issues.apache.org/jira/browse/METRON-1158
> Project: Metron
> Issue Type: New Feature
> Reporter: Justin Leet
> Assignee: Justin Leet
>
> We should be able to handle meta alerts (manually grouped alerts, particularly from the UI) in the system. This should be integrated with the DAO composition put into place with IndexDao.
> While similar to faceting (and likely resulting from slicing and dicing from faceting), these need to be interacted with and queryable alongside regular alerts.
> This needs to handle:
> * ES (as a starting point. This shouldn't preclude Solr)
> * Creation of meta alerts
> * Maintain update semantics for alerts
> * Handling scores when a child alert is added, updated or deleted.
> * Continue to allow regular alerts to flow through cleanly to the original sensor indices.
> * Allow for querying (plus sorting and so on) alongside the original sensor indices.
> * Maintain UI grouping order as the minimum of metadata.
> * This should be configured via the same indexDao definition (or at least similar) as the other indexDaos.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)