You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/11/25 13:44:02 UTC
[PR] fix and reenable testSkip_RequiredCharsets [commons-io]
elharo opened a new pull request, #518:
URL: https://github.com/apache/commons-io/pull/518
The problem in this test was asserting something that simply wasn't true and wasn't expected to be true in many cases. Removing the offending assert allowed some redundant tests to be removed.
@garydgregory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix and reenable testSkip_RequiredCharsets [commons-io]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #518:
URL: https://github.com/apache/commons-io/pull/518#issuecomment-1826325119
## [Codecov](https://app.codecov.io/gh/apache/commons-io/pull/518?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`b54ac95`)](https://app.codecov.io/gh/apache/commons-io/commit/b54ac951c940449709ed25d1f908e008bb56e28d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 86.13% compared to head [(`4844a07`)](https://app.codecov.io/gh/apache/commons-io/pull/518?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 86.13%.
> Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #518 +/- ##
=========================================
Coverage 86.13% 86.13%
Complexity 3427 3427
=========================================
Files 229 229
Lines 8140 8140
Branches 959 959
=========================================
Hits 7011 7011
Misses 850 850
Partials 279 279
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-io/pull/518?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fx and reenable testSkip_RequiredCharsets [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #518:
URL: https://github.com/apache/commons-io/pull/518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org