You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/13 12:00:44 UTC
[GitHub] [kafka] AsWali opened a new pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
AsWali opened a new pull request #10313:
URL: https://github.com/apache/kafka/pull/10313
Minor modification suggested in the following issue: https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-12456?filter=addedrecently
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ikdekker commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
ikdekker commented on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799845091
By the way, I sent my JIRA username to the dev mail, not sure if i should have typed some extra lines there. But then I might try again 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799800389
@ikdekker Hmm. When you run another test, old files are deleted. Try copy and pasting the file path directly after running a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ikdekker commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
ikdekker commented on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799798100
Hi @jolshan,
I have looked into my build directories. The ones that my gradle outputs after running tests. These do not contain the reports. For example, both clients and streams modules do not contain an html file:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799770551
Hi @ikdekker. I'm not a committer, but I can answer some of your questions.
The report you mentioned was generated to the builds directory. If you copy and paste the file path into a web browser, you should be able to see the result.
As for the JIRA ticket, the `KAFKA-12456` at the start of the PR title will automatically link this PR to the ticket. If you'd like access to editing the ticket, you can create an Apache JIRA account. Then simply ask for JIRA permissions by sending your JIRA username to dev@kafka.apache.org
Hope this helps!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan edited a comment on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
jolshan edited a comment on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799824018
@ikdekker You don't need to follow any of the quickstart steps to run the tests. Simply running `./gradlew test` or any subset of tests should do the trick.
As for `core:test` not outputting a report, that may be due to the build passing (no failed tests). If it says "BUILD SUCESSFUL" you are good to go.
With streams, I noticed a gradle error in the screenshot above. If the run is incomplete, the report file may not be generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan edited a comment on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
jolshan edited a comment on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799842000
@ikdekker Hmm. The best advice I can give here is running `./gradlew clean` and trying again.
I've seen plenty of green runs with core tests, but yes, it usually takes 20 min or so. For running shorter tests, try `core:unitTest`
Please develop in trunk. This should be the most up-to-date branch and reports should generate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan edited a comment on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
jolshan edited a comment on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799824018
@ikdekker You don't need to follow any of the quickstart steps to run the tests. Simply running `./gradlew test` or any subset of tests should do the trick.
As for `core:test` not outputting a report, that may be due to the build passing (no failed tests). If it says "BUILD SUCESSFUL" you are good to go.
EDIT: oh hmmm, you are right. It should still output the result to the file. I'm not sure about why that is not happening, but it should be. It shows up for me.
With streams, I noticed a gradle error in the screenshot above. If the run is incomplete, the report file may not be generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan edited a comment on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
jolshan edited a comment on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799770551
Hi @ikdekker. I'm not a committer, but I can answer some of your questions.
The report you mentioned was generated to the builds directory. If you copy and paste the file path into a web browser, you should be able to see the result.
As for the JIRA ticket, the `KAFKA-12456` at the start of the PR title will automatically link this PR to the ticket. If you'd like access to editing the ticket, you can create an Apache JIRA account. Then simply ask for JIRA permissions by sending your JIRA username to dev@kafka.apache.org
More info on mailing lists here: http://kafka.apache.org/contact
Hope this helps!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799824018
@ikdekker You don't need to follow any of the quickstart steps to run the tests. Simply running `./gradlew test` or any subset of tests should do the trick.
As for `core:test` not generating a report, that may be due to the build passing (no failed tests). If it says "BUILD SUCESSFUL" you are good to go.
With streams, I noticed a gradle error in the screenshot above. If the run is incomplete, the report file may not be generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ikdekker commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
ikdekker commented on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-798355603
Hello Kafka Committers,
this contribution is part of a university course. We would appreciate any kind of feedback. This initial PR is purposefully a very simple one for us to get familiar with the process of PRs in this repo.
We attempted running tests (by executing `./gradlew tests`), but reports were not generated. The test output did indicate a report was generated into the builds directory. Is this a known issue, or expected behaviour? We followed the Readme as stated in the contributing page (https://github.com/apache/kafka/blob/trunk/README.md).
Thanks for your time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799842000
@ikdekker Hmm. The best advice I can give here is running `./gradlew clean` and trying again.
I've seen plenty of green runs with core tests, but yes, it usually takes 20 min or so.
Please develop in trunk. This should be the most up-to-date branch and reports should generate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ikdekker commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
ikdekker commented on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799813229
Directly after running (all tests), I see only a clients index.html, streams and core do not generate a report, even when running `./gradlew streams:test` or `./gradlew core:test` (which would be relevant for this PR).
The streams tests seem to take a very long time and many fail due to connection timeouts. Is it necessary to start Zookeeper for these tests? The command at https://kafka.apache.org/quickstart throws an error, which may require some Zookeeper setup:
`Error: Could not find or load main class org.apache.zookeeper.server.quorum.QuorumPeerMain
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ikdekker commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
ikdekker commented on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799843740
Alright, I will check some things out. This PR was created from trunk. I might try to create some tests myself, which I should be able to get output from as a starting point. Thanks again for your time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ikdekker commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
ikdekker commented on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799830566
Running core:tests takes around 20 minutes and fails at the end. If it is as you say and simply running the gradle, is it expected to have some failures? For example for tests that need authentication.
core:tests output is:
```
2479 tests completed, 257 failed, 13 skipped
> Task :core:test FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':core:test'.
> Process 'Gradle Test Executor 4' finished with non-zero exit value 1
This problem might be caused by incorrect test process configuration.
Please refer to the test execution section in the User Manual at https://docs.gradle.org/6.8.3/userguide/java_testing.html#sec:test_execution
BUILD FAILED in 22m 13s
28 actionable tasks: 3 executed, 25 up-to-date
```
An example of failure with auth:
```
kafka.api.DescribeAuthorizedOperationsTest > testConsumerGroupAuthorizedOperations FAILED
org.apache.kafka.common.KafkaException: javax.security.auth.login.LoginException: Could not login: the client is being asked for a password, but the Kafka client code does not currently support obtaining a password from the user. not available to garner authentication information from the user
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ikdekker edited a comment on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
ikdekker edited a comment on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799830566
Running core:tests takes around 20 minutes and fails at the end. If it is as you say and simply running the gradle, is it expected to have some failures? For example for tests that need authentication.
core:tests output is:
```
2479 tests completed, 257 failed, 13 skipped
> Task :core:test FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':core:test'.
> Process 'Gradle Test Executor 4' finished with non-zero exit value 1
This problem might be caused by incorrect test process configuration.
Please refer to the test execution section in the User Manual at https://docs.gradle.org/6.8.3/userguide/java_testing.html#sec:test_execution
BUILD FAILED in 22m 13s
28 actionable tasks: 3 executed, 25 up-to-date
```
An example of failure with auth:
```
kafka.api.DescribeAuthorizedOperationsTest > testConsumerGroupAuthorizedOperations FAILED
org.apache.kafka.common.KafkaException: javax.security.auth.login.LoginException: Could not login: the client is being asked for a password, but the Kafka client code does not currently support obtaining a password from the user. not available to garner authentication information from the user
```
By the way, should the trunk branch also have this report generation, or is it unstable? And from which branch do you recommend to start the PR, 2.8?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ikdekker edited a comment on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
ikdekker edited a comment on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-798355603
Hello Kafka Committers,
this contribution is part of a university course. We would appreciate any kind of feedback. This initial PR is purposefully a very simple one for us to get familiar with the process of PRs in this repo.
We attempted running tests (by executing `./gradlew tests`), but reports were not generated. The test output did indicate a report was generated into the builds directory. Is this a known issue, or expected behaviour? We followed the Readme as stated in the contributing page (https://github.com/apache/kafka/blob/trunk/README.md).
On the [PR guideline page](https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes), it says we should update the status of https://issues.apache.org/jira/browse/KAFKA-12456 to submit a patch. It seems we do not have the rights to do this, is this right?
Thanks for your time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ikdekker edited a comment on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR
Posted by GitBox <gi...@apache.org>.
ikdekker edited a comment on pull request #10313:
URL: https://github.com/apache/kafka/pull/10313#issuecomment-799798100
Hi @jolshan,
Thanks for the response!
I have looked into my build directories. The ones that my gradle outputs after running tests. These do not contain the reports. For example, both clients and streams modules do not contain an html file:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org