You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Freeman Fang (JIRA)" <ji...@apache.org> on 2008/10/08 11:05:52 UTC
[jira] Created: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
New JMS in/out provider should support temporary queues/topics (as reply destinations)
--------------------------------------------------------------------------------------
Key: SM-1621
URL: https://issues.apache.org/activemq/browse/SM-1621
Project: ServiceMix
Issue Type: Improvement
Affects Versions: 3.2.2
Reporter: Freeman Fang
Assignee: Freeman Fang
Fix For: servicemix-jms-2008.02
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ron Gavlin reopened SM-1621:
----------------------------
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.2.3, servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated SM-1621:
--------------------------------
Fix Version/s: servicemix-jms-2008.01
(was: servicemix-jms-2008.02)
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: servicemix-jms-2008.01, 3.3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48389#action_48389 ]
Gert Vanthienen commented on SM-1621:
-------------------------------------
Javier,
The unit test has been added to both locations, but the fix for the temporary destinations has only been committed to the servicemix-jms component trunk used for ServiceMix 3.3 and 4.0 (cfr. http://svn.eu.apache.org/viewvc/servicemix/components/bindings/servicemix-jms/trunk/)
Regards,
Gert
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.3.1, 3.2.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46431#action_46431 ]
Freeman Fang commented on SM-1621:
----------------------------------
commit fix to servicemix-jms component project
http://svn.apache.org/viewvc?rev=704440&view=rev
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.2.3, servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "javier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48388#action_48388 ]
javier commented on SM-1621:
----------------------------
hi Freeman,
i can find this fix in the svn, the last committed revision for it is 702802.
i'm checking it in http://svn.apache.org/repos/asf/servicemix/smx3/branches/servicemix-3.2/deployables/bindingcomponents/servicemix-jms/src/main/java/org/apache/servicemix/jms/endpoints/JmsProviderEndpoint.java
what am i doing wrong?
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.3.1, 3.2.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (SM-1621) New JMS in/out provider should
support temporary queues/topics (as reply destinations)
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on SM-1621 started by Freeman Fang.
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47104#action_47104 ]
Ron Gavlin commented on SM-1621:
--------------------------------
My xbean.xml configuration is listed below:
<jms:provider service="person:PersonServiceProvider"
endpoint="PersonSMXJMSPortProvider"
destinationName="dynamicQueues/personSMXJMS.queue"
connectionFactory="#connectionFactory" />
<jms:consumer service="person:PersonService"
endpoint="PersonSMXJMSPort"
targetService="person:async-bridge"
targetEndpoint="endpoint"
destinationName="dynamicQueues/personSMXJMS.queue"
connectionFactory="#connectionFactory"
marshaler="#marshaler" />
<bean id="marshaler" class="org.apache.servicemix.jms.endpoints.DefaultConsumerMarshaler">
<property name="mep" value="http://www.w3.org/2004/08/wsdl/in-out" />
</bean>/>
When I send a message to the provider endpoint above, the following exception is generated in the smx log:
ERROR - JmsComponent - Error processing exchange InOut[
id: ID:10.10.10.10-11d71050a92-4:0
status: Active
role: provider
service: {http://servicemix.apache.org/samples/wsdl-first}PersonServiceProvider
endpoint: PersonSMXJMSPortProvider
operation: {http://servicemix.apache.org/samples/wsdl-first}GetPerson
in: <?xml version="1.0" encoding="UTF-8"?><jbi:message xmlns:jbi="http://java.sun.com/xml/ns/jbi/wsdl-11-wrapper" xmln
s:msg="http://servicemix.apache.org/samples/wsdl-first" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://w
ww.w3.org/2001/XMLSchema-instance" name="GetPersonRequest" type="msg:GetPersonRequest" version="1.0"><jbi:part><tns:GetP
erson xmlns:tns="http://servicemix.apache.org/samples/wsdl-first/types">
<tns:personId xmlns:tns="http://servicemix.apache.org/samples/wsdl-first/types">world</tns:personId>
</tns:GetPerson></jbi:part></jbi:message>
out: null
]
org.springframework.jms.InvalidDestinationException: Cannot use a Temporary destination from another Connection; nested
exception is javax.jms.InvalidDestinationException: Cannot use a Temporary destination from another Connection
Caused by:
javax.jms.InvalidDestinationException: Cannot use a Temporary destination from another Connection
at org.apache.activemq.ActiveMQMessageConsumer.<init>(ActiveMQMessageConsumer.java:160)
at org.apache.activemq.ActiveMQSession.createConsumer(ActiveMQSession.java:1006)
at org.apache.activemq.ActiveMQSession.createConsumer(ActiveMQSession.java:950)
at org.apache.activemq.ActiveMQSession.createConsumer(ActiveMQSession.java:863)
at org.springframework.jms.core.JmsTemplate.createConsumer(JmsTemplate.java:873)
at org.springframework.jms.core.JmsTemplate.doReceive(JmsTemplate.java:681)
at org.springframework.jms.core.JmsTemplate$10.doInJms(JmsTemplate.java:656)
at org.springframework.jms.core.JmsTemplate.execute(JmsTemplate.java:437)
at org.springframework.jms.core.JmsTemplate.receiveSelected(JmsTemplate.java:654)
at org.apache.servicemix.jms.endpoints.JmsProviderEndpoint.processInOutInSession(JmsProviderEndpoint.java:417)
at org.apache.servicemix.jms.endpoints.JmsProviderEndpoint$2.doInJms(JmsProviderEndpoint.java:380)
at org.springframework.jms.core.JmsTemplate.execute(JmsTemplate.java:437)
at org.apache.servicemix.jms.endpoints.JmsProviderEndpoint.processInOut(JmsProviderEndpoint.java:391)
at org.apache.servicemix.common.endpoints.ProviderEndpoint.process(ProviderEndpoint.java:109)
at org.apache.servicemix.common.AsyncBaseLifeCycle.doProcess(AsyncBaseLifeCycle.java:540)
at org.apache.servicemix.common.AsyncBaseLifeCycle.processExchange(AsyncBaseLifeCycle.java:492)
at org.apache.servicemix.common.BaseLifeCycle.onMessageExchange(BaseLifeCycle.java:46)
at org.apache.servicemix.jbi.messaging.DeliveryChannelImpl.processInBound(DeliveryChannelImpl.java:621)
at org.apache.servicemix.jbi.nmr.flow.AbstractFlow.doRouting(AbstractFlow.java:172)
at org.apache.servicemix.jbi.nmr.flow.seda.SedaFlow.doRouting(SedaFlow.java:167)
at org.apache.servicemix.jbi.nmr.flow.seda.SedaQueue$1.run(SedaQueue.java:134)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
at java.lang.Thread.run(Thread.java:595)
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.2.3, servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47163#action_47163 ]
Freeman Fang commented on SM-1621:
----------------------------------
after digging the code, I found that the spring JmsTemplate always create a connection and then close it, so the connection from which we create temporary queue/topic will lost, but according to JMS, the temporary queue/topic should only used for the connection which create the temporary queue/topic, that's why we see the exception "Cannot use a Temporary destination from another Connection"
One workaround now is customer needn't specify the replyDestination, in this case our code will create a queue/topic with name whatever like "anonymous" as the replyDestination, but it's not real temporay queue/topic :-(
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.2.3, servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang updated SM-1621:
-----------------------------
Fix Version/s: 3.3
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.3, servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved SM-1621.
------------------------------
Fix Version/s: 3.3.1
3.2.4
(was: 3.2.3)
(was: servicemix-jms-2008.02)
Resolution: Fixed
commit fix
http://svn.apache.org/viewvc?rev=712123&view=rev for 3.2 branch
http://svn.apache.org/viewvc?rev=712124&view=rev for servicemix-jms component project
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.3.1, 3.2.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48390#action_48390 ]
Freeman Fang commented on SM-1621:
----------------------------------
Javier,
As I commented, for 3.2 branch, it's just configuration issue so we add test to demonstrate how to configure it.
But for 3.3 branch, since we introduce the MessageListenerContainer, so we need add the ListenerContainer also for the tempoary destination, which means we need fix for servicemix-jms component.
Freeman
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.3.1, 3.2.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47174#action_47174 ]
Freeman Fang commented on SM-1621:
----------------------------------
Hi Ron,
Google a bit, the article here [1] inspired me, per as James Strachan's suggest, we should use PooledConnectionFactory with spring jms template.
So the xbean.xml for your jms su should be
<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns:jms="http://servicemix.apache.org/jms/1.0"
xmlns:tns="http://fusesource.com/jmsinoutbug"
xmlns:amq="http://activemq.org/config/1.0">
<jms:provider service="tns:jmsprovider" endpoint="provider"
destinationName="requests.queue"
connectionFactory="#pooledConnectionFactory"/>
<bean id ="pooledConnectionFactory" class="org.apache.activemq.pool.PooledConnectionFactory">
<property name="connectionFactory">
<bean class="org.apache.activemq.ActiveMQConnectionFactory">
<property name="brokerURL" value="tcp://localhost:61616" />
</bean>
</property>
</bean>
</beans>
Just change xbean configuration should work with 3.2 branch
But for 3.3 branch, since we introduce the MessageListenerContainer, so we need add the ListenerContainer also for the tempoary destination.
I will commit fix for 3.3 branch and tests for both.
[1]http://www.theserverside.com/news/thread.tss?thread_id=37740
Cheers
Freeman
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.2.3, servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47165#action_47165 ]
Ron Gavlin commented on SM-1621:
--------------------------------
Hi Freeman,
I am not sure I understand your workaround. In my failing example above, I did not specify the replyDestination. Your workaround seems to suggest "the customer needn't specify the replyDestination". Did you mean to say "the customer must specify a replyDestination"? If so, then yes, I agree this could be an interim workaround.
Have you had a chance to review the new JMS transport code in CXF based on Spring JMS? I believe it supports temporary replyDestinations.
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.2.3, servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46255#action_46255 ]
Freeman Fang commented on SM-1621:
----------------------------------
if there is no replyDestination explictly set, then get chance to create temp queue/topic
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang updated SM-1621:
-----------------------------
Fix Version/s: 3.2.3
servicemix-jms-2008.02
(was: 3.3)
(was: servicemix-jms-2008.01)
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.2.3, servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SM-1621) New JMS in/out provider should support
temporary queues/topics (as reply destinations)
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved SM-1621.
------------------------------
Resolution: Fixed
Sending servicemix-jms/src/main/java/org/apache/servicemix/jms/endpoints/JmsProviderEndpoint.java
Transmitting file data .
Committed revision 702802.
> New JMS in/out provider should support temporary queues/topics (as reply destinations)
> --------------------------------------------------------------------------------------
>
> Key: SM-1621
> URL: https://issues.apache.org/activemq/browse/SM-1621
> Project: ServiceMix
> Issue Type: Improvement
> Affects Versions: 3.2.2
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 3.3, servicemix-jms-2008.02
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.