[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1657: change kie label env to environment

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #1657: change kie label env to environment
URL: https://github.com/apache/servicecomb-java-chassis/pull/1657#discussion_r396836836
 
 

 ##########
 File path: dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieUtil.java
 ##########
 @@ -65,7 +65,7 @@ public static String encrypt(String dataStr) {
       //todo:how to deal env
       if (labelsMap.containsKey("app") && labelsMap.get("app")
           .equals(KieConfig.INSTANCE.getAppName())
-          && labelsMap.containsKey("env") && labelsMap.get("env")
+          && labelsMap.containsKey("environment") && labelsMap.get("environment")
 
 Review comment:
   Too many literals in a function, better to define constants for them. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services