You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Yifan Cai (Jira)" <ji...@apache.org> on 2022/09/21 22:01:00 UTC
[jira] [Comment Edited] (CASSANDRA-17870) nodetool/rebuild: Add flag to exclude nodes from local datacenter
[ https://issues.apache.org/jira/browse/CASSANDRA-17870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607984#comment-17607984 ]
Yifan Cai edited comment on CASSANDRA-17870 at 9/21/22 10:00 PM:
-----------------------------------------------------------------
Can you send a PR instead? It can be created on [https://github.com/apache/cassandra]
Why prefer excluding the local DC instead of setting a source DC?
was (Author: yifanc):
Can you send a PR instead? It can be created on [https://github.com/apache/cassandra]
> nodetool/rebuild: Add flag to exclude nodes from local datacenter
> -----------------------------------------------------------------
>
> Key: CASSANDRA-17870
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17870
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
> Reporter: Saranya Krishnakumar
> Assignee: Saranya Krishnakumar
> Priority: Normal
> Attachments: fix_nodetool_rebuild.diff
>
>
> During expansion by Dc, when we issue nodetool/rebuild from new dc to rebuild the data from other DCs. If src-dc is not passed explicitly, then C* tries to rebuild the data from the same (new dc) dc.
> We don’t exclude other nodes in the same DC. Only down sources and the local node itself are excluded.
> ```
> // We're _always_ filtering out a local node and down sources
> addSourceFilter(new RangeStreamer.FailureDetectorSourceFilter(failureDetector));
> addSourceFilter(new RangeStreamer.ExcludeLocalNodeFilter());
> ```
> We should fix nodetool/rebuild to exclude the local DC (from where we’re executing the command) while issuing nodetool/rebuild without passing src dc
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org