[GitHub] [airflow] potiuk opened a new pull request #13431: Adds timeout to all curl commands

[GitBox <gi...@apache.org>]

potiuk opened a new pull request #13431:
URL: https://github.com/apache/airflow/pull/13431


   Curl has a sophisticated back-off mechanism when trying to connect
   and it causes sometimes that it hangs for a very long time
   when first few attempts to connect failed with a 'soft' error.
   Similarly, when curl starts transfer after connecting but the
   other party hanged, the client curl call might hang as well.
   
   This causes various problems for example sometimes waitig for
   images in the ci build gets cancelled because curl command
   to check for image fails - example:
   
   https://github.com/apache/airflow/pull/13413/checks?check_run_id=1635401914
   
   This change adds appropriate timeouts to all curl commands we
   use in CI/manual operations. In many cases we implemented
   retry so the effect will be that those cases will stop happening
   but even in no-retry case, failing curl is better than hangs.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #13431: Adds timeout to all curl commands

[GitBox <gi...@apache.org>]

github-actions[bot] commented on pull request #13431:
URL: https://github.com/apache/airflow/pull/13431#issuecomment-753465532


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #13431: Adds timeout to all curl commands

[GitBox <gi...@apache.org>]

potiuk merged pull request #13431:
URL: https://github.com/apache/airflow/pull/13431


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org