You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/08/01 06:04:12 UTC
Re: Review Request 61257: Added full authz for non summarized fields
of `/slaves` endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61257/#review181878
-----------------------------------------------------------
src/master/http.cpp
Lines 489-491 (original), 490-493 (patched)
<https://reviews.apache.org/r/61257/#comment257669>
As mentioned in the parent review, perhaps we should authorize on the canonical resource format, and then convert afterward.
- Greg Mann
On July 31, 2017, 2:01 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61257/
> -----------------------------------------------------------
>
> (Updated July 31, 2017, 2:01 p.m.)
>
>
> Review request for mesos, Adam B, Greg Mann, Quinn Leng, and Till Toenshoff.
>
>
> Bugs: MESOS-7416
> https://issues.apache.org/jira/browse/MESOS-7416
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fields were authorized based on partial elements of each
> resource. Moreover, some fields which required authorization were not
> being authorized at all. This patch enables full authorization of all
> fields.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70
>
>
> Diff: https://reviews.apache.org/r/61257/diff/1/
>
>
> Testing
> -------
>
> ```shell
> make check
> ```
>
>
> Thanks,
>
> Alexander Rojas
>
>