You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by RobberPhex <gi...@git.apache.org> on 2017/12/28 11:08:21 UTC
[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1451
THRIFT-4438: delete trusty and requrie php56
* remove support php 5.3, 5.4 and 5.5
* remove test at ubuntu trusty(trusty only have php5.5, haven't php5.6)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift php56
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1451.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1451
----
commit b960a1e447457d2eba98dad75e4ebf023b5504de
Author: Robert Lu <ro...@...>
Date: 2017-12-28T10:07:08Z
delete trusty and requrie php56
----
---
[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56
Posted by RobberPhex <gi...@git.apache.org>.
Github user RobberPhex closed the pull request at:
https://github.com/apache/thrift/pull/1451
---
[GitHub] thrift issue #1451: THRIFT-4438: delete trusty and requrie php56
Posted by RobberPhex <gi...@git.apache.org>.
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1451
Considering that trusty haven't reached end of life, so I close this pr, and keep trusty in CI.
---
[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1451#discussion_r161777001
--- Diff: build/docker/ubuntu-trusty/Dockerfile ---
@@ -1,223 +0,0 @@
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-#
-# Apache Thrift Docker build environment for Ubuntu Trusty
-# Using all stock Ubuntu Trusty packaging except for:
-# - d: does not come with Ubuntu so we're installing 2.070.0
-# - dart: does not come with Ubuntu so we're installing 1.20.1
-# - dotnetcore, disabled because netcore is for 1.0.0-preview and 2.0.0 is out
-# - haxe, disabled because the distro comes with 3.0.0 and it cores while installing
-# - node.js, disabled because it is at 0.10.0 in the distro which is too old (need 4+)
-# - ocaml, disabled because it fails to install properly
-#
--- End diff --
Recommend adding that php is disabled because we require 5.6 and Trusty comes with 5.5.9, and comment out the PHP lines, but not delete the whole thing.
---
[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1451#discussion_r161777313
--- Diff: composer.json ---
@@ -16,12 +16,12 @@
"issues": "https://issues.apache.org/jira/browse/THRIFT"
},
"require": {
- "php": ">=5.3.0"
+ "php": "^5.6 || ^7.0"
--- End diff --
Just looking at the changes here for dropping php 5.3 through 5.5, what's the benefit? No php code actually changed to take advantage of this, so I'm not sure I see a reason to do it?
---
[GitHub] thrift issue #1451: THRIFT-4438: delete trusty and requrie php56
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1451
Thanks, given there were no structural changes to php other than dropping 5.3 from the compatibility list, I think this is best for now.
---