You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anurag Singh <an...@gmail.com> on 2016/04/04 19:08:25 UTC
Re: Review Request 44669: Implemented create methods in
MasterContender and MasterDetector.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44669/
-----------------------------------------------------------
(Updated April 4, 2016, 5:08 p.m.)
Review request for mesos, Benjamin Hindman and Kapil Arya.
Summary (updated)
-----------------
Implemented create methods in MasterContender and MasterDetector.
Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610
Repository: mesos
Description (updated)
-------
The create method can be used to create a MasterContender/Detector from a
module (specified using the --modules flag on the command line). If the
contender/detector module names have not been specified, the method will
fall back to its prior behavior.
Diffs (updated)
-----
include/mesos/master/contender.hpp PRE-CREATION
include/mesos/master/detector.hpp PRE-CREATION
src/master/contenders/contender.cpp PRE-CREATION
src/master/detectors/detector.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44669/diff/
Testing
-------
See https://reviews.apache.org/r/44670/.
Thanks,
Anurag Singh
Re: Review Request 44669: Implemented create methods in
MasterContender and MasterDetector.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44669/#review127488
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On April 6, 2016, 12:03 p.m., Anurag Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44669/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 12:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kapil Arya.
>
>
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The create method can be used to create a MasterContender/Detector from a
> module (specified using the --modules flag on the command line). If the
> contender/detector module names have not been specified, the method will
> fall back to its prior behavior.
>
>
> Diffs
> -----
>
> include/mesos/master/contender.hpp PRE-CREATION
> include/mesos/master/detector.hpp PRE-CREATION
> src/master/contender/contender.cpp PRE-CREATION
> src/master/detector/detector.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44669/diff/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/44670/.
>
>
> Thanks,
>
> Anurag Singh
>
>
Re: Review Request 44669: Implemented create methods in
MasterContender and MasterDetector.
Posted by Anurag Singh <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44669/
-----------------------------------------------------------
(Updated April 6, 2016, 4:03 p.m.)
Review request for mesos, Benjamin Hindman and Kapil Arya.
Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610
Repository: mesos
Description
-------
The create method can be used to create a MasterContender/Detector from a
module (specified using the --modules flag on the command line). If the
contender/detector module names have not been specified, the method will
fall back to its prior behavior.
Diffs (updated)
-----
include/mesos/master/contender.hpp PRE-CREATION
include/mesos/master/detector.hpp PRE-CREATION
src/master/contender/contender.cpp PRE-CREATION
src/master/detector/detector.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44669/diff/
Testing
-------
See https://reviews.apache.org/r/44670/.
Thanks,
Anurag Singh
Re: Review Request 44669: Implemented create methods in
MasterContender and MasterDetector.
Posted by Anurag Singh <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44669/
-----------------------------------------------------------
(Updated April 6, 2016, 3:14 p.m.)
Review request for mesos, Benjamin Hindman and Kapil Arya.
Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610
Repository: mesos
Description
-------
The create method can be used to create a MasterContender/Detector from a
module (specified using the --modules flag on the command line). If the
contender/detector module names have not been specified, the method will
fall back to its prior behavior.
Diffs (updated)
-----
include/mesos/master/contender.hpp PRE-CREATION
include/mesos/master/detector.hpp PRE-CREATION
src/master/contender/contender.cpp PRE-CREATION
src/master/detector/detector.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44669/diff/
Testing
-------
See https://reviews.apache.org/r/44670/.
Thanks,
Anurag Singh