[GitHub] [incubator-pinot] jackjlli edited a comment on pull request #6229: Add profile release-sign-artifacts for pinot-spark-connector

[GitBox <gi...@apache.org>]

jackjlli edited a comment on pull request #6229:
URL: https://github.com/apache/incubator-pinot/pull/6229#issuecomment-721429629


   > Can the `scala-maven-plugin` run before the default pgp plugin signed the files?
   
   No, basically the `maven-source-plugin` and `scala-maven-plugin` respectively have their own life cycles. And the default pgp plugin is executed in the first life cycle. Without explicitly specifying the gpg/pgp plugin to the pom file, maven doesn't know whether this is the correct sequence. That's why I put the gpg plugin here right after the scala plugin. And my change will guarantee that the gpg plugin will sign the files **only once** at the end of the mvn command, so no double signing.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org