You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Mike Rettig (JIRA)" <ji...@apache.org> on 2014/12/04 18:21:12 UTC

[jira] [Commented] (THRIFT-2260) Thrift imposes unneeded dependency on commons-lang3

    [ https://issues.apache.org/jira/browse/THRIFT-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234376#comment-14234376 ] 

Mike Rettig commented on THRIFT-2260:
-------------------------------------

The new implementation could be a lot faster if it didn't create a List and box all the primitives.

> Thrift imposes unneeded dependency on commons-lang3
> ---------------------------------------------------
>
>                 Key: THRIFT-2260
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2260
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler
>    Affects Versions: 0.9.1
>            Reporter: Andrew Gaul
>            Assignee: Roger Meier
>            Priority: Minor
>             Fix For: 0.9.2
>
>         Attachments: THRIFT-2260.patch
>
>
> Thrift depends on commons-lang3, yet only uses HashCodeBuilder.  We can  rely on the default List.hashCode implementation and remove this 300 KB dependency.  This will prepare the generator for removing the hashcode option and always generating high-quality hash codes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)