[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #32: [FLINK-26367] Move sanity check in `FlinkService#cancelJob` to `DefaultDeploymentValidator`

[GitBox <gi...@apache.org>]

wangyang0918 commented on a change in pull request #32:
URL: https://github.com/apache/flink-kubernetes-operator/pull/32#discussion_r817323906



##########
File path: flink-kubernetes-webhook/pom.xml
##########
@@ -50,6 +50,12 @@ under the License.
             <version>${flink.version}</version>
         </dependency>
 
+        <dependency>

Review comment:
       Instead of introducing a direct dependency `flink-runtime`, I suggest to update the exclusions in `flink-kubernetes-operator` dependency.
   ```
           <dependency>
               <groupId>org.apache.flink</groupId>
               <artifactId>flink-kubernetes-operator</artifactId>
               <version>${project.version}</version>
               <exclusions>
                   <exclusion>
                       <groupId>org.apache.flink</groupId>
                       <artifactId>flink-core</artifactId>
                   </exclusion>
                   <exclusion>
                       <groupId>org.apache.flink</groupId>
                       <artifactId>flink-shaded-netty</artifactId>
                   </exclusion>
               </exclusions>
           </dependency>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org