You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "CV-Bowen (via GitHub)" <gi...@apache.org> on 2023/02/25 14:46:57 UTC

[GitHub] [nuttx] CV-Bowen opened a new pull request, #8653: sched/env: add tg_envc in task_group_s to avoid some loops in code

CV-Bowen opened a new pull request, #8653:
URL: https://github.com/apache/nuttx/pull/8653

   ## Summary
   this commit optimize the env api speed by avoiding some loops (while/for) in code
   
   ## Impact
   should be none
   
   ## Testing
   sim:ostest pass
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] acassis commented on pull request #8653: sched/env: add tg_envc in task_group_s to avoid some loops in code

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8653:
URL: https://github.com/apache/nuttx/pull/8653#issuecomment-1445140871

   Hi @CV-Bowen did you make some profiling tests? How much it improves the execution time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8653: sched/env: add tg_envc in task_group_s to avoid some loops in code

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8653:
URL: https://github.com/apache/nuttx/pull/8653#issuecomment-1445162048

   > I think some time in the past we have count of variables, but moved away from it. @xiaoxiang781216 most probably can provide more details. Anyway I will review.
   
   Yes, but the layout is change:
   
   1. The old way save all env in one big char array like this "env1=value1\0env2=value2"
   2. The new way save all env in array of char array like this {"env1=value1", "env2=value2", NULL}
   
   Layout 2 is required implicitly by environ: https://pubs.opengroup.org/onlinepubs/7908799/xsh/environ.html
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on pull request #8653: sched/env: add tg_envc in task_group_s to avoid some loops in code

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #8653:
URL: https://github.com/apache/nuttx/pull/8653#issuecomment-1445158800

   I think some time in the past we have count of variables, but moved away from it. @xiaoxiang781216 most probably can provide more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko merged pull request #8653: sched/env: add tg_envc in task_group_s to avoid some loops in code

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #8653:
URL: https://github.com/apache/nuttx/pull/8653


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org