You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/14 07:03:37 UTC
[GitHub] [incubator-doris] blackfox1983 opened a new pull request #3315: fix
bug of issue 3287
blackfox1983 opened a new pull request #3315: fix bug of issue 3287
URL: https://github.com/apache/incubator-doris/pull/3315
#3287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request
#3315: fix bug of issue 3287
Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on a change in pull request #3315: fix bug of issue 3287
URL: https://github.com/apache/incubator-doris/pull/3315#discussion_r407910495
##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -129,14 +140,13 @@ static const string ERROR_COL_DATA_IS_ARRAY = "Data source returned an array for
template <typename T>
static Status get_int_value(const rapidjson::Value &col, PrimitiveType type, void* slot, bool pure_doc_value) {
-
-
if (col.IsNumber()) {
*reinterpret_cast<T*>(slot) = (T)(sizeof(T) < 8 ? col.GetInt() : col.GetInt64());
return Status::OK();
}
if (pure_doc_value && col.IsArray()) {
+ RETURN_ERROR_IF_COL_IS_NOT_NUMBER(col, type);
Review comment:
Can you delete the extra leading space?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request
#3315: fix bug of issue 3287
Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on a change in pull request #3315: fix bug of issue 3287
URL: https://github.com/apache/incubator-doris/pull/3315#discussion_r407971344
##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -129,14 +140,13 @@ static const string ERROR_COL_DATA_IS_ARRAY = "Data source returned an array for
template <typename T>
static Status get_int_value(const rapidjson::Value &col, PrimitiveType type, void* slot, bool pure_doc_value) {
-
-
if (col.IsNumber()) {
*reinterpret_cast<T*>(slot) = (T)(sizeof(T) < 8 ? col.GetInt() : col.GetInt64());
return Status::OK();
}
if (pure_doc_value && col.IsArray()) {
+ RETURN_ERROR_IF_COL_IS_NOT_NUMBER(col, type);
Review comment:
col is an array
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #3315: fix bug of issue
3287
Posted by GitBox <gi...@apache.org>.
imay merged pull request #3315: fix bug of issue 3287
URL: https://github.com/apache/incubator-doris/pull/3315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org