[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32184: [SPARK-35083][CORE] Support remote scheduler pool file using hadoop api

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #32184:
URL: https://github.com/apache/spark/pull/32184#discussion_r614115181



##########
File path: core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala
##########
@@ -74,7 +76,8 @@ private[spark] class FairSchedulableBuilder(val rootPool: Pool, conf: SparkConf)
     var fileData: Option[(InputStream, String)] = None
     try {
       fileData = schedulerAllocFile.map { f =>
-        val fis = new FileInputStream(f)
+        val filePath = new Path(f)
+        val fis = filePath.getFileSystem(sc.hadoopConfiguration).open(filePath)

Review comment:
       This code can do many things. Please see my above comment. (https://github.com/apache/spark/pull/32184#issuecomment-820459844)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org