You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/01/09 01:04:52 UTC
[kudu-CR] KUDU-2195. Add additional gflag to force sync of consensus metadata
Hello Alexey Serbin, Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12186
to review the following change.
Change subject: KUDU-2195. Add additional gflag to force sync of consensus metadata
......................................................................
KUDU-2195. Add additional gflag to force sync of consensus metadata
This patch adds an override gflag for consensus metadata fsync so that
XFS users are less likely to lose their consensus metadata files while
voting right before a power outage.
Change-Id: I73212d1670a33479cce7d9ef9ee61cfe9b00cdd3
---
M src/kudu/consensus/consensus_meta.cc
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/12186/1
--
To view, visit http://gerrit.cloudera.org:8080/12186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73212d1670a33479cce7d9ef9ee61cfe9b00cdd3
Gerrit-Change-Number: 12186
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2195. Add additional gflag to force sync of consensus metadata
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12186 )
Change subject: KUDU-2195. Add additional gflag to force sync of consensus metadata
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73212d1670a33479cce7d9ef9ee61cfe9b00cdd3
Gerrit-Change-Number: 12186
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 09 Jan 2019 06:48:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2195. Add additional gflag to force sync of consensus metadata
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12186 )
Change subject: KUDU-2195. Add additional gflag to force sync of consensus metadata
......................................................................
Patch Set 1: Code-Review+2
Seems harmless enough.
--
To view, visit http://gerrit.cloudera.org:8080/12186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73212d1670a33479cce7d9ef9ee61cfe9b00cdd3
Gerrit-Change-Number: 12186
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 09 Jan 2019 05:45:53 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2195. Add additional gflag to force sync of consensus metadata
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12186 )
Change subject: KUDU-2195. Add additional gflag to force sync of consensus metadata
......................................................................
KUDU-2195. Add additional gflag to force sync of consensus metadata
This patch adds an override gflag for consensus metadata fsync so that
XFS users are less likely to lose their consensus metadata files while
voting right before a power outage.
Change-Id: I73212d1670a33479cce7d9ef9ee61cfe9b00cdd3
Reviewed-on: http://gerrit.cloudera.org:8080/12186
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/consensus_meta.cc
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I73212d1670a33479cce7d9ef9ee61cfe9b00cdd3
Gerrit-Change-Number: 12186
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>