[GitHub] [mahout] andrewmusselman commented on a diff in pull request #423: MAHOUT-2151 Add Scaladocs to AsFactor.scala

["andrewmusselman (via GitHub)" <gi...@apache.org>]

andrewmusselman commented on code in PR #423:
URL: https://github.com/apache/mahout/pull/423#discussion_r1100492640


##########
core/src/main/scala/org/apache/mahout/math/algorithms/preprocessing/AsFactor.scala:
##########
@@ -29,8 +29,18 @@ import org.apache.mahout.math.scalabindings._
 import org.apache.mahout.math.scalabindings.RLikeOps._
 import MahoutCollections._
 
+/**
+  * AsFactor is a preprocessor that turns a vector of integers into a vector of one-hot encoded

Review Comment:
   I'd change this to "matrix" instead of "vector of integers"



##########
core/src/main/scala/org/apache/mahout/math/algorithms/preprocessing/AsFactor.scala:
##########
@@ -92,6 +115,12 @@ class AsFactorModel(cardinality: Int, factorVec: MahoutVector) extends Preproces
     res
   }
 
+  /**
+    * Inverse transform the input data - ie transform a one-hot encoded DrmLike[K] into a

Review Comment:
   I don't know what this method does but that comment doesn't look complete..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org