You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/12 07:46:36 UTC
Review Request 43520: Speed up
GarbageCollectorIntegrationTest.Restart.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172
Repository: mesos
Description
-------
Speed up GarbageCollectorIntegrationTest.Restart.
Diffs
-----
src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
Diff: https://reviews.apache.org/r/43520/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 43520: Speed up
GarbageCollectorIntegrationTest.Restart.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/#review127972
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43520]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 9, 2016, 6:18 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43520/
> -----------------------------------------------------------
>
> (Updated April 9, 2016, 6:18 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Bugs: MESOS-4172
> https://issues.apache.org/jira/browse/MESOS-4172
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up GarbageCollectorIntegrationTest.Restart by advance allocation
> interval.
>
>
> Diffs
> -----
>
> src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6
>
> Diff: https://reviews.apache.org/r/43520/diff/
>
>
> Testing
> -------
>
> Repeat test in CentOS 7.1
>
> ```
> $ sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose --gtest_repeat=200 --gtest_break_on_failure
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43520: Speeded up
GarbageCollectorIntegrationTest.Restart.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/#review129252
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43520]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 16, 2016, 3:37 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43520/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 3:37 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Bugs: MESOS-4172
> https://issues.apache.org/jira/browse/MESOS-4172
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up GarbageCollectorIntegrationTest.Restart by reduce
> `executor_shutdown_grace_period`.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5
>
> Diff: https://reviews.apache.org/r/43520/diff/
>
>
> Testing
> -------
>
> Repeat test in CentOS 7.1
>
> ```
> $ sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose --gtest_repeat=200 --gtest_break_on_failure
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43520: Speeded up
GarbageCollectorIntegrationTest.Restart.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
-----------------------------------------------------------
(Updated April 16, 2016, 3:37 p.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Changes
-------
Speed up GarbageCollectorIntegrationTest.Restart by reduce
`executor_shutdown_grace_period`.
Summary (updated)
-----------------
Speeded up GarbageCollectorIntegrationTest.Restart.
Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172
Repository: mesos
Description (updated)
-------
Speed up GarbageCollectorIntegrationTest.Restart by reduce
`executor_shutdown_grace_period`.
Diffs (updated)
-----
src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5
Diff: https://reviews.apache.org/r/43520/diff/
Testing
-------
Repeat test in CentOS 7.1
```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose --gtest_repeat=200 --gtest_break_on_failure
```
Thanks,
haosdent huang
Re: Review Request 43520: Speed up
GarbageCollectorIntegrationTest.Restart.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
-----------------------------------------------------------
(Updated April 9, 2016, 6:18 a.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Changes
-------
Update description.
Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172
Repository: mesos
Description (updated)
-------
Speed up GarbageCollectorIntegrationTest.Restart by advance allocation
interval.
Diffs
-----
src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6
Diff: https://reviews.apache.org/r/43520/diff/
Testing
-------
Repeat test in CentOS 7.1
```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose --gtest_repeat=200 --gtest_break_on_failure
```
Thanks,
haosdent huang
Re: Review Request 43520: Speed up
GarbageCollectorIntegrationTest.Restart.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
-----------------------------------------------------------
(Updated April 9, 2016, 6:09 a.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Changes
-------
Update according to @alexr's comments.
Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172
Repository: mesos
Description
-------
Speed up GarbageCollectorIntegrationTest.Restart.
Diffs (updated)
-----
src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6
Diff: https://reviews.apache.org/r/43520/diff/
Testing (updated)
-------
Repeat test in CentOS 7.1
```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose --gtest_repeat=200 --gtest_break_on_failure
```
Thanks,
haosdent huang
Re: Review Request 43520: Speed up
GarbageCollectorIntegrationTest.Restart.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/#review118991
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43520]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 12, 2016, 6:46 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43520/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2016, 6:46 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4172
> https://issues.apache.org/jira/browse/MESOS-4172
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up GarbageCollectorIntegrationTest.Restart.
>
>
> Diffs
> -----
>
> src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
>
> Diff: https://reviews.apache.org/r/43520/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>