You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/11/16 04:01:20 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-414 - Contain result ins...
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/436
ZEPPELIN-414 - Contain result inside paragraph
Taking care of https://issues.apache.org/jira/browse/ZEPPELIN-414
I only applied it on ``HTML`` and ``ANGULAR`` result, because it is the only one that i saw breaking.
Didn't have any problem with other types, although I couldn't test with the response type ``IMG``, any good example to test it?
Here is how it looks now:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/ZEPPELIN-414
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/436.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #436
----
commit 1cf6921bba01064054cafe9408e8596aa7119399
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-11-16T02:57:54Z
Add overflow auto to html and angular result container
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-414 - Contain result ins...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/436#issuecomment-156900444
Ready for reviews, @Leemoonsoo @gauravkumar37 if you have some nice tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-414 - Contain result ins...
Posted by gauravkumar37 <gi...@git.apache.org>.
Github user gauravkumar37 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/436#issuecomment-164337013
@corneadoug Ah I see, I guess it's a bug of cross browser compatibility.
I can see the full text in Chrome but in Firefox v42, the result shows in only 1 line and a horizontal scrollbar is shown in the full page. The results extend horizontally beyond the result div.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-414 - Contain result ins...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/436#issuecomment-157248651
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-414 - Contain result ins...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/436
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-414 - Contain result ins...
Posted by gauravkumar37 <gi...@git.apache.org>.
Github user gauravkumar37 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/436#issuecomment-164243249
This PR wraps the HTML output but does not wrap sysout output.
The output of `println(1 to 1000)` is not wrapped.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-414 - Contain result ins...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/436#issuecomment-164326184
_text don't need to be wrapped since it is text and we always show the full text.
<img width="1353" alt="screen shot 2015-12-14 at 11 34 40 am" src="https://cloud.githubusercontent.com/assets/710411/11771663/ce1bcd5e-a256-11e5-9744-a65c02c647c9.png">
This is what I get when running ``println(1 to 1000)`` and it is the full result sent by the server
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-414 - Contain result ins...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/436#issuecomment-164345438
@gauravkumar37 I just created this issue:
https://issues.apache.org/jira/browse/ZEPPELIN-500
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-414 - Contain result ins...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/436#issuecomment-156995056
I have a notebook that have result larger than paragraph width. Tested with this PR and i can see it is fixed.
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---