[jira] [Commented] (HDFS-7168) Use excludedNodes consistently in DFSOutputStream

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152659#comment-14152659 ] 

Hadoop QA commented on HDFS-7168:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12671916/HDFS-7168.001.patch
  against trunk revision c88c6c5.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestDFSClientExcludedNodes

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8259//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8259//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8259//console

This message is automatically generated.

> Use excludedNodes consistently in DFSOutputStream
> -------------------------------------------------
>
>                 Key: HDFS-7168
>                 URL: https://issues.apache.org/jira/browse/HDFS-7168
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-7168.001.patch
>
>
> We currently have two separate collections of excluded nodes in the {{DFSOutputStream#DataStreamer}}.  One is {{DFSOutputStream#failed}}; another is {{DFSOutputStream#excludedNodes}}.  Both of these collections just deal with blacklisting nodes that we have found to be bad.  We should just use excludedNodes for both.
> We also should make this a per-DFSOutputStream variable, rather than being per-DataStreamer.  We don't need to forget all this information whenever a DataStreamer is torn down.  Since {{DFSOutputStream#excludedNodes}} is a Guava cache, nodes will expire out of it once enough time elapses, so they will not be permanently blacklisted.
> We should also remove {{DFSOutputStream#setTestFilename}}, since it is no longer needed now that we can safely rename streams that are open for write.  And {{DFSOutputStream#getBlock}} should be synchronized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)