You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/12/22 12:51:48 UTC
[PR] [DRAFT] Test different pekko versions [incubator-pekko-connectors]
pjfanning opened a new pull request, #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293
* not yet ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293#discussion_r1435707437
##########
.github/workflows/nightly-pekko-1.1-builds.yaml:
##########
@@ -0,0 +1,39 @@
+name: Nightly Pekko 1.1 Builds
+
+on:
+ schedule:
+ - cron: "0 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
+
+concurrency:
+ # Only run once for latest commit per ref and cancel other (previous) runs.
+ group: ci-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ style-compile-mima:
+ name: Compile
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
+ with:
+ fetch-tags: true
+ fetch-depth: 0
+
+ - name: Setup Java 8
+ uses: actions/setup-java@v4
+ with:
+ distribution: temurin
+ java-version: 8
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6.4.0
+
+ - name: "compile, including tests. Run locally with: sbt +Test/compile"
+ run: sbt -Dpekko.build.pekko.version=1.0.x +Test/compile
Review Comment:
I see, so you plan to have a 1.1.0-M1 release then :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293#discussion_r1435706068
##########
.github/workflows/nightly-pekko-1.1-builds.yaml:
##########
@@ -0,0 +1,39 @@
+name: Nightly Pekko 1.1 Builds
+
+on:
+ schedule:
+ - cron: "0 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
+
+concurrency:
+ # Only run once for latest commit per ref and cancel other (previous) runs.
+ group: ci-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ style-compile-mima:
+ name: Compile
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
+ with:
+ fetch-tags: true
+ fetch-depth: 0
+
+ - name: Setup Java 8
+ uses: actions/setup-java@v4
+ with:
+ distribution: temurin
+ java-version: 8
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6.4.0
+
+ - name: "compile, including tests. Run locally with: sbt +Test/compile"
+ run: sbt +Test/compile
Review Comment:
add a new line here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293#discussion_r1435708659
##########
.github/workflows/nightly-pekko-1.1-builds.yaml:
##########
@@ -0,0 +1,39 @@
+name: Nightly Pekko 1.1 Builds
+
+on:
+ schedule:
+ - cron: "0 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
+
+concurrency:
+ # Only run once for latest commit per ref and cancel other (previous) runs.
+ group: ci-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ style-compile-mima:
+ name: Compile
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
+ with:
+ fetch-tags: true
+ fetch-depth: 0
+
+ - name: Setup Java 8
+ uses: actions/setup-java@v4
+ with:
+ distribution: temurin
+ java-version: 8
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6.4.0
+
+ - name: "compile, including tests. Run locally with: sbt +Test/compile"
+ run: sbt -Dpekko.build.pekko.version=1.0.x +Test/compile
Review Comment:
part of preparing for pekko 1.1 is to start testing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293#issuecomment-1868372282
> @pjfanning Do we need a runner for Java 21 too? People may jump from Java 8 to Java 21, I think test these two should be OK.
I've updated the 1.1 job to test with multiple JDKs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293#issuecomment-1868382961
@pjfanning Is it possible to do the source code changes (i.e. moving the `deprecated`) in another PR rather than this one? If its not related to adding testing for Pekko 1.0/1.1 I would rather keep the commits separate otherwise its confusing when we need to look back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293#discussion_r1435706692
##########
.github/workflows/nightly-pekko-1.1-builds.yaml:
##########
@@ -0,0 +1,39 @@
+name: Nightly Pekko 1.1 Builds
+
+on:
+ schedule:
+ - cron: "0 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
+
+concurrency:
+ # Only run once for latest commit per ref and cancel other (previous) runs.
+ group: ci-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ style-compile-mima:
+ name: Compile
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
Review Comment:
Where the version 1.1.x is setted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293#issuecomment-1868371028
@pjfanning Do we need a runner for Java 21 too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293#issuecomment-1868384333
@mdedetrich I've dropped the code changes for java 17/21. They will be done later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293#discussion_r1435707149
##########
.github/workflows/nightly-pekko-1.1-builds.yaml:
##########
@@ -0,0 +1,39 @@
+name: Nightly Pekko 1.1 Builds
+
+on:
+ schedule:
+ - cron: "0 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
+
+concurrency:
+ # Only run once for latest commit per ref and cancel other (previous) runs.
+ group: ci-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ style-compile-mima:
+ name: Compile
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
Review Comment:
added to the sbt command below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Also test with pekko 1.1 [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #293:
URL: https://github.com/apache/incubator-pekko-connectors/pull/293#discussion_r1435706723
##########
.github/workflows/nightly-pekko-1.1-builds.yaml:
##########
@@ -0,0 +1,39 @@
+name: Nightly Pekko 1.1 Builds
+
+on:
+ schedule:
+ - cron: "0 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
+
+concurrency:
+ # Only run once for latest commit per ref and cancel other (previous) runs.
+ group: ci-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ style-compile-mima:
+ name: Compile
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
Review Comment:
thanks - added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org