You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/01/17 17:30:56 UTC
Review Request 42440: Create a test macro to advance `Clock` for
`Future`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42440/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and Timothy Chen.
Bugs: MESOS-4418
https://issues.apache.org/jira/browse/MESOS-4418
Repository: mesos
Description
-------
Create a test macro to advance `Clock` for `Future`.
Diffs
-----
3rdparty/libprocess/include/process/gtest.hpp 049152c0535c78e6986346610735d301fb6876bc
Diff: https://reviews.apache.org/r/42440/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42440: Create a test macro to advance `Clock` for
`Future`.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42440/#review114909
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42440]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 17, 2016, 4:30 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42440/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2016, 4:30 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and Timothy Chen.
>
>
> Bugs: MESOS-4418
> https://issues.apache.org/jira/browse/MESOS-4418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Create a test macro to advance `Clock` for `Future`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gtest.hpp 049152c0535c78e6986346610735d301fb6876bc
>
> Diff: https://reviews.apache.org/r/42440/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42440: Create a test macro to advance `Clock` for
`Future`.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42440/#review117766
-----------------------------------------------------------
Ship it!
Ship It!
- Jian Qiu
On 一月 22, 2016, 4:56 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42440/
> -----------------------------------------------------------
>
> (Updated 一月 22, 2016, 4:56 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and Timothy Chen.
>
>
> Bugs: MESOS-4418
> https://issues.apache.org/jira/browse/MESOS-4418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Create a test macro to advance `Clock` for `Future`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gtest.hpp 049152c0535c78e6986346610735d301fb6876bc
>
> Diff: https://reviews.apache.org/r/42440/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42440: Create a test macro to advance `Clock` for
`Future`.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42440/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 4:56 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and Timothy Chen.
Changes
-------
Address @qiujian's comments
Bugs: MESOS-4418
https://issues.apache.org/jira/browse/MESOS-4418
Repository: mesos
Description
-------
Create a test macro to advance `Clock` for `Future`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/gtest.hpp 049152c0535c78e6986346610735d301fb6876bc
Diff: https://reviews.apache.org/r/42440/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42440: Create a test macro to advance `Clock` for
`Future`.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 22, 2016, 1:54 p.m., Jian Qiu wrote:
> > 3rdparty/libprocess/include/process/gtest.hpp, line 65
> > <https://reviews.apache.org/r/42440/diff/1/?file=1199505#file1199505line65>
> >
> > If the clock is paused outside, there is no need to pause here
Thank you very much, could you help review again?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42440/#review115842
-----------------------------------------------------------
On Jan. 22, 2016, 4:56 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42440/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 4:56 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and Timothy Chen.
>
>
> Bugs: MESOS-4418
> https://issues.apache.org/jira/browse/MESOS-4418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Create a test macro to advance `Clock` for `Future`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gtest.hpp 049152c0535c78e6986346610735d301fb6876bc
>
> Diff: https://reviews.apache.org/r/42440/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42440: Create a test macro to advance `Clock` for
`Future`.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42440/#review115842
-----------------------------------------------------------
3rdparty/libprocess/include/process/gtest.hpp (line 63)
<https://reviews.apache.org/r/42440/#comment176906>
Maybe change this to advanceInterval?
3rdparty/libprocess/include/process/gtest.hpp (line 65)
<https://reviews.apache.org/r/42440/#comment176905>
If the clock is paused outside, there is no need to pause here
- Jian Qiu
On 一月 17, 2016, 4:30 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42440/
> -----------------------------------------------------------
>
> (Updated 一月 17, 2016, 4:30 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and Timothy Chen.
>
>
> Bugs: MESOS-4418
> https://issues.apache.org/jira/browse/MESOS-4418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Create a test macro to advance `Clock` for `Future`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gtest.hpp 049152c0535c78e6986346610735d301fb6876bc
>
> Diff: https://reviews.apache.org/r/42440/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>