You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2002/07/10 18:12:53 UTC

Re: svn commit: rev 2457 - trunk/www

kfogel@tigris.org wrote:
> 
> Author: kfogel
> Date: Wed, 10 Jul 2002 12:07:28 -0500
> New Revision: 2457
> * subversion/www/project_faq.html (db-recover): New question.

Karl,

The path in this log message and in revisions 512, 906, 933, 1312,
1313, 1314, 1467, 1472, 1637, 1638, 1743, 2044, 2371, 2383, 2384
all have "subversion/" before www/project_faq.html, which doesn't
actually exist.  I think there are other log messages to files
in www that have the subversion prepended.

We may want to have a log message checker to make sure that the
paths listed in the log message actually exist.

Best,
Blair

-- 
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 2457 - trunk/www

Posted by cm...@collab.net.
Blair Zajac <bl...@orcaware.com> writes:

> Karl Fogel wrote:
> > 
> > Blair Zajac <bl...@orcaware.com> writes:
> > > The path in this log message and in revisions 512, 906, 933, 1312,
> > > 1313, 1314, 1467, 1472, 1637, 1638, 1743, 2044, 2371, 2383, 2384
> > > all have "subversion/" before www/project_faq.html, which doesn't
> > > actually exist.  I think there are other log messages to files
> > > in www that have the subversion prepended.
> > 
> > Okay, these are all taken care of now, along with 2051, 280, 932,
> > 2342, 1927, 1568, 1567, 1566, 1448, 1144, 624, 548, 378, 1753, 1145,
> > 2353, 1334, 2136, 1587, 1537, 1318, 1317, 1019, 710, 1669, 2437, 2430,
> > 2327, 1777, 1642, 1293, 1279, 730, 729, 2424, 609, 1328, 1599, 1352,
> > 2431, 2393, 2214, 2191, 2166, 2165, 2123, 1701, 1650, 1636, 1564,
> > 1466, 1359, 718, 701, and 694.
> > 
> > :-)
> 
> Cool.  Thanks.  I'm guessing you didn't use the web interface for
> this :)  You fixed these fast.

Actually, he did.  He's JUST THAT DARNED FAST.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 2457 - trunk/www

Posted by Blair Zajac <bl...@orcaware.com>.
Karl Fogel wrote:
> 
> Blair Zajac <bl...@orcaware.com> writes:
> > The path in this log message and in revisions 512, 906, 933, 1312,
> > 1313, 1314, 1467, 1472, 1637, 1638, 1743, 2044, 2371, 2383, 2384
> > all have "subversion/" before www/project_faq.html, which doesn't
> > actually exist.  I think there are other log messages to files
> > in www that have the subversion prepended.
> 
> Okay, these are all taken care of now, along with 2051, 280, 932,
> 2342, 1927, 1568, 1567, 1566, 1448, 1144, 624, 548, 378, 1753, 1145,
> 2353, 1334, 2136, 1587, 1537, 1318, 1317, 1019, 710, 1669, 2437, 2430,
> 2327, 1777, 1642, 1293, 1279, 730, 729, 2424, 609, 1328, 1599, 1352,
> 2431, 2393, 2214, 2191, 2166, 2165, 2123, 1701, 1650, 1636, 1564,
> 1466, 1359, 718, 701, and 694.
> 
> :-)

Cool.  Thanks.  I'm guessing you didn't use the web interface for
this :)  You fixed these fast.

Blair

-- 
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 2457 - trunk/www

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Blair Zajac <bl...@orcaware.com> writes:
> The path in this log message and in revisions 512, 906, 933, 1312,
> 1313, 1314, 1467, 1472, 1637, 1638, 1743, 2044, 2371, 2383, 2384
> all have "subversion/" before www/project_faq.html, which doesn't
> actually exist.  I think there are other log messages to files
> in www that have the subversion prepended.

Okay, these are all taken care of now, along with 2051, 280, 932,
2342, 1927, 1568, 1567, 1566, 1448, 1144, 624, 548, 378, 1753, 1145,
2353, 1334, 2136, 1587, 1537, 1318, 1317, 1019, 710, 1669, 2437, 2430,
2327, 1777, 1642, 1293, 1279, 730, 729, 2424, 609, 1328, 1599, 1352,
2431, 2393, 2214, 2191, 2166, 2165, 2123, 1701, 1650, 1636, 1564,
1466, 1359, 718, 701, and 694.

:-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 2457 - trunk/www

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Blair Zajac <bl...@orcaware.com> writes:
> The path in this log message and in revisions 512, 906, 933, 1312,
> 1313, 1314, 1467, 1472, 1637, 1638, 1743, 2044, 2371, 2383, 2384
> all have "subversion/" before www/project_faq.html, which doesn't
> actually exist.  I think there are other log messages to files
> in www that have the subversion prepended.
> 
> We may want to have a log message checker to make sure that the
> paths listed in the log message actually exist.

Heh.  No, it exists, but not in the repository -- my working copy is
named "subversion" here, so for example, I have

   /home/kfogel/src/subversion/subversion/libsvn_wc/diff.c

and

   /home/kfogel/src/subversion/www/project_faq.html

and so on.  Obviously the name of my top-level working copy should not
be relevant to other users of the repository -- I could have called it
"fish" if I wanted, wouldn't matter.  The problem here is a bug in
some elisp code I have that generates log message paths for me.  I'll
fix that.

I will correct old repository log messages on a case-by-case basis
Probably not today, but soon.

I don't think there's any need for our log messages script to protect
against this.  There are all sorts of errors a person could make
(should it check that the name function actually exists in the named
file, too?), after all.

Thanks for noticing,
-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org