[jira] [Commented] (PROTON-2326) epoll proactor housecleaning

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268761#comment-17268761 ] 

ASF GitHub Bot commented on PROTON-2326:
----------------------------------------

cliffjansen opened a new pull request #290:
URL: https://github.com/apache/qpid-proton/pull/290


   Part 1 of epoll proactor code cleanup:
   
    wake->schedule
    context->task
    wake_notify -> notify_poller
    WAKE -> EVENT_FD (epoll_type-t)
    wake_pending, wake_list_xxx -> ready, ready_list_xxx
    similar changes to use of wake and ctx as local vars
    unused sched_wakes_pending removed
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> epoll proactor housecleaning
> ----------------------------
>
>                 Key: PROTON-2326
>                 URL: https://issues.apache.org/jira/browse/PROTON-2326
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>    Affects Versions: proton-c-0.33.0
>         Environment: Linux systems with epoll.
>            Reporter: Clifford Jansen
>            Assignee: Clifford Jansen
>            Priority: Major
>
> Improve clarity and maintainability of code. Replace overloaded naming (i.e. "wake", "context") with less ambiguous terms. Rationalize comments over many previous internal refactors. Consolidate wake/wakeable concept at the task level rather than as separate implementations per task type.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org