You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/18 06:17:52 UTC
[GitHub] [incubator-doris] xinyiZzz opened a new pull request, #9661: [fix][memory tracker] Fix lru cache, compaction tracker, add NO_MEM_TRACKER compile
xinyiZzz opened a new pull request, #9661:
URL: https://github.com/apache/incubator-doris/pull/9661
# Proposed changes
Issue Number: close #9540
## Problem Summary:
1. Fix Lru Cache MemTracker consumption value is negative.
2. Fix compaction Cache MemTracker has no track.
3. Add NO_MEM_TRACKER compile option.
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
3. Has unit tests been added: (No Need)
4. Has document been added or modified: (No Need)
5. Does it need to update dependencies: (No)
6. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9661: [fix][memory tracker] Fix lru cache, compaction tracker, add USE_MEM_TRACKER compile
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9661:
URL: https://github.com/apache/incubator-doris/pull/9661#issuecomment-1135940064
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9661: [fix][memory tracker] Fix lru cache, compaction tracker, add USE_MEM_TRACKER compile
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9661:
URL: https://github.com/apache/incubator-doris/pull/9661#discussion_r876003480
##########
build.sh:
##########
@@ -212,6 +212,9 @@ fi
if [[ -z ${STRIP_DEBUG_INFO} ]]; then
STRIP_DEBUG_INFO=OFF
fi
+if [[ -z ${USE_MEM_TRACKER} ]]; then
Review Comment:
Add comment to explain this parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9661: [fix][memory tracker] Fix lru cache, compaction tracker, add USE_MEM_TRACKER compile
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9661:
URL: https://github.com/apache/incubator-doris/pull/9661#issuecomment-1135940018
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9661: [fix][memory tracker] Fix lru cache, compaction tracker, add USE_MEM_TRACKER compile
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9661:
URL: https://github.com/apache/incubator-doris/pull/9661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #9661: [fix][memory tracker] Fix lru cache, compaction tracker, add USE_MEM_TRACKER compile
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on code in PR #9661:
URL: https://github.com/apache/incubator-doris/pull/9661#discussion_r878959916
##########
build.sh:
##########
@@ -212,6 +212,9 @@ fi
if [[ -z ${STRIP_DEBUG_INFO} ]]; then
STRIP_DEBUG_INFO=OFF
fi
+if [[ -z ${USE_MEM_TRACKER} ]]; then
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org