You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com> on 2016/02/02 13:17:57 UTC
[VOTE] InAppBrowser Plugin Release
Please review and vote on the InAppBrowser plugin release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10505
The plugin has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10505/
The package were published from their corresponding git tag:
cordova-plugin-inappbrowser: 1.2.1 (df94a6c157)
Upon a successful vote I will upload the archives to dist/, upload them to the Plugins Registry, and post the corresponding blog post.
Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
* Run auto tests for iOS, Android and Windows
-Sergey
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: [VOTE] InAppBrowser Plugin Release
Posted by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com>.
Hi Sean, such discussion should happen in [Discuss] thread, before vote is started. CB-7786 introduces new functionality so this should be in minor or major release anyway. I've reviewed your PR and it looks good, I'll merge it later today.
Thx!
-Sergey
-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com]
Sent: Wednesday, February 3, 2016 5:44 AM
To: dev@cordova.apache.org
Subject: Re: [VOTE] InAppBrowser Plugin Release
Hey Sean,
We only -1 if it is a regression or major bug found. I would say CB-7786 doesn't qualify as either of those.
According to ASF policies, only PMC members can vote.
I know you have been trying to get someone to review your PR. I'll bug some people tomorrow to see if we can get it reviewed and in the next inappbrowser plugin release. We can do another inappbrowser release shortly after.
Cheers,
-Steve
On Tue, Feb 2, 2016 at 6:39 PM, Sean Kelly <ho...@seank.com> wrote:
> I'd vote no. I'd really like to see CB-7786 get in before the next release.
>
> SeanK
>
> On Tue, Feb 2, 2016 at 4:17 AM, Sergey Grebnov (Akvelon) <
> v-segreb@microsoft.com> wrote:
>
> > Please review and vote on the InAppBrowser plugin release by
> > replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> > ues.apache.org%2fjira%2fbrowse%2fCB-10505&data=01%7c01%7cv-segreb%40
> > microsoft.com%7c594a03e53e384d3cfc7008d32c43fc36%7c72f988bf86f141af9
> > 1ab2d7cd011db47%7c1&sdata=UhXz%2bhfLfjU0cK16GNLrW0Bmmeqi1hzwEET2zeae
> > mQU%3d
> >
> > The plugin has been published to dist/dev:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdis
> > t.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10505%2f&data=01%7c
> > 01%7cv-segreb%40microsoft.com%7c594a03e53e384d3cfc7008d32c43fc36%7c7
> > 2f988bf86f141af91ab2d7cd011db47%7c1&sdata=bDfFos9mxYdJZ27CMfUl2sNMH7
> > G2X%2fBaI4GbfmgUVQ8%3d
> >
> > The package were published from their corresponding git tag:
> > cordova-plugin-inappbrowser: 1.2.1 (df94a6c157)
> >
> > Upon a successful vote I will upload the archives to dist/, upload
> > them
> to
> > the Plugins Registry, and post the corresponding blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> .md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Run auto tests for iOS, Android and Windows
> >
> > -Sergey
> >
> > --------------------------------------------------------------------
> > - To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>
Re: [VOTE] InAppBrowser Plugin Release
Posted by Steven Gill <st...@gmail.com>.
Hey Sean,
We only -1 if it is a regression or major bug found. I would say CB-7786
doesn't qualify as either of those.
According to ASF policies, only PMC members can vote.
I know you have been trying to get someone to review your PR. I'll bug some
people tomorrow to see if we can get it reviewed and in the next
inappbrowser plugin release. We can do another inappbrowser release shortly
after.
Cheers,
-Steve
On Tue, Feb 2, 2016 at 6:39 PM, Sean Kelly <ho...@seank.com> wrote:
> I'd vote no. I'd really like to see CB-7786 get in before the next release.
>
> SeanK
>
> On Tue, Feb 2, 2016 at 4:17 AM, Sergey Grebnov (Akvelon) <
> v-segreb@microsoft.com> wrote:
>
> > Please review and vote on the InAppBrowser plugin release
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-10505
> >
> > The plugin has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-10505/
> >
> > The package were published from their corresponding git tag:
> > cordova-plugin-inappbrowser: 1.2.1 (df94a6c157)
> >
> > Upon a successful vote I will upload the archives to dist/, upload them
> to
> > the Plugins Registry, and post the corresponding blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Run auto tests for iOS, Android and Windows
> >
> > -Sergey
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>
Re: [VOTE] InAppBrowser Plugin Release
Posted by Sean Kelly <ho...@seank.com>.
I'd vote no. I'd really like to see CB-7786 get in before the next release.
SeanK
On Tue, Feb 2, 2016 at 4:17 AM, Sergey Grebnov (Akvelon) <
v-segreb@microsoft.com> wrote:
> Please review and vote on the InAppBrowser plugin release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10505
>
> The plugin has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-10505/
>
> The package were published from their corresponding git tag:
> cordova-plugin-inappbrowser: 1.2.1 (df94a6c157)
>
> Upon a successful vote I will upload the archives to dist/, upload them to
> the Plugins Registry, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Run auto tests for iOS, Android and Windows
>
> -Sergey
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: [VOTE] InAppBrowser Plugin Release
Posted by Sean Kelly <ho...@seank.com>.
Sorry to be such a pain, I realize this is a thankless job and I want you
to know I appreciate all your work.
On Thu, Feb 4, 2016 at 5:26 AM, Sergey Grebnov (Akvelon) <
v-segreb@microsoft.com> wrote:
> The vote has now closed. The results are:
>
> Positive Binding Votes: 3
>
> Vladimir Kotikov
> Alexander Sorokin
> Sergey Grebnov
>
> Negative Binding Votes: 0
>
> Other Votes:
> -1 from Sean Kelly
>
> The vote has passed.
>
> -Sergey
> -----Original Message-----
> From: Vladimir Kotikov (Akvelon) [mailto:v-vlkoti@microsoft.com]
> Sent: Thursday, February 4, 2016 2:38 PM
> To: dev@cordova.apache.org
> Subject: RE: [VOTE] InAppBrowser Plugin Release
>
> I vote +1.
>
> * Verified signatures and hashes
> * Ran coho audit-license-headers over the repo
> * Ran plugin auto tests to ensure they are passing
>
> -
> Best regards, Vladimir
>
> -----Original Message-----
> From: Alexander Sorokin (Akvelon) [mailto:v-alsoro@microsoft.com]
> Sent: Wednesday, February 3, 2016 7:45 PM
> To: dev@cordova.apache.org
> Subject: RE: [VOTE] InAppBrowser Plugin Release
>
> I vote +1.
>
> * Verified signatures and hashes
> * Verified tag
> * Verified that plugin can be added correctly to blank app
> * Verified that blank app can be successfully built and ran
> * Ran smoke testing of mobilespec app
> * Verified release notes
>
> -----Original Message-----
> From: Sergey Grebnov (Akvelon) [mailto:v-segreb@microsoft.com]
> Sent: Tuesday, February 2, 2016 3:18 PM
> To: dev@cordova.apache.org
> Subject: [VOTE] InAppBrowser Plugin Release
>
> Please review and vote on the InAppBrowser plugin release by replying to
> this email (and keep discussion on the DISCUSS thread)
>
> Release issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10505&data=01%7c01%7cv-alsoro%40microsoft.com%7c02e2cb1dd3b04708dcbb08d32bcaed28%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cG6Ib7IA9nvojJhyKguPJCOWmRQPzEHLIq%2fW3Xbl2QA%3d
>
> The plugin has been published to dist/dev:
>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10505%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7c02e2cb1dd3b04708dcbb08d32bcaed28%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cPPdrfmroj3uU36AoedqJ4rV64q0wTVgtI7Zlvfia5Q%3d
>
> The package were published from their corresponding git tag:
> cordova-plugin-inappbrowser: 1.2.1 (df94a6c157)
>
> Upon a successful vote I will upload the archives to dist/, upload them to
> the Plugins Registry, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Run auto tests for iOS, Android and Windows
>
> -Sergey
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
RE: [VOTE] InAppBrowser Plugin Release
Posted by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com>.
The vote has now closed. The results are:
Positive Binding Votes: 3
Vladimir Kotikov
Alexander Sorokin
Sergey Grebnov
Negative Binding Votes: 0
Other Votes:
-1 from Sean Kelly
The vote has passed.
-Sergey
-----Original Message-----
From: Vladimir Kotikov (Akvelon) [mailto:v-vlkoti@microsoft.com]
Sent: Thursday, February 4, 2016 2:38 PM
To: dev@cordova.apache.org
Subject: RE: [VOTE] InAppBrowser Plugin Release
I vote +1.
* Verified signatures and hashes
* Ran coho audit-license-headers over the repo
* Ran plugin auto tests to ensure they are passing
-
Best regards, Vladimir
-----Original Message-----
From: Alexander Sorokin (Akvelon) [mailto:v-alsoro@microsoft.com]
Sent: Wednesday, February 3, 2016 7:45 PM
To: dev@cordova.apache.org
Subject: RE: [VOTE] InAppBrowser Plugin Release
I vote +1.
* Verified signatures and hashes
* Verified tag
* Verified that plugin can be added correctly to blank app
* Verified that blank app can be successfully built and ran
* Ran smoke testing of mobilespec app
* Verified release notes
-----Original Message-----
From: Sergey Grebnov (Akvelon) [mailto:v-segreb@microsoft.com]
Sent: Tuesday, February 2, 2016 3:18 PM
To: dev@cordova.apache.org
Subject: [VOTE] InAppBrowser Plugin Release
Please review and vote on the InAppBrowser plugin release by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10505&data=01%7c01%7cv-alsoro%40microsoft.com%7c02e2cb1dd3b04708dcbb08d32bcaed28%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cG6Ib7IA9nvojJhyKguPJCOWmRQPzEHLIq%2fW3Xbl2QA%3d
The plugin has been published to dist/dev:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10505%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7c02e2cb1dd3b04708dcbb08d32bcaed28%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cPPdrfmroj3uU36AoedqJ4rV64q0wTVgtI7Zlvfia5Q%3d
The package were published from their corresponding git tag:
cordova-plugin-inappbrowser: 1.2.1 (df94a6c157)
Upon a successful vote I will upload the archives to dist/, upload them to the Plugins Registry, and post the corresponding blog post.
Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
* Run auto tests for iOS, Android and Windows
-Sergey
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: [VOTE] InAppBrowser Plugin Release
Posted by "Vladimir Kotikov (Akvelon)" <v-...@microsoft.com>.
I vote +1.
* Verified signatures and hashes
* Ran coho audit-license-headers over the repo
* Ran plugin auto tests to ensure they are passing
-
Best regards, Vladimir
-----Original Message-----
From: Alexander Sorokin (Akvelon) [mailto:v-alsoro@microsoft.com]
Sent: Wednesday, February 3, 2016 7:45 PM
To: dev@cordova.apache.org
Subject: RE: [VOTE] InAppBrowser Plugin Release
I vote +1.
* Verified signatures and hashes
* Verified tag
* Verified that plugin can be added correctly to blank app
* Verified that blank app can be successfully built and ran
* Ran smoke testing of mobilespec app
* Verified release notes
-----Original Message-----
From: Sergey Grebnov (Akvelon) [mailto:v-segreb@microsoft.com]
Sent: Tuesday, February 2, 2016 3:18 PM
To: dev@cordova.apache.org
Subject: [VOTE] InAppBrowser Plugin Release
Please review and vote on the InAppBrowser plugin release by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10505&data=01%7c01%7cv-alsoro%40microsoft.com%7c02e2cb1dd3b04708dcbb08d32bcaed28%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cG6Ib7IA9nvojJhyKguPJCOWmRQPzEHLIq%2fW3Xbl2QA%3d
The plugin has been published to dist/dev:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10505%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7c02e2cb1dd3b04708dcbb08d32bcaed28%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cPPdrfmroj3uU36AoedqJ4rV64q0wTVgtI7Zlvfia5Q%3d
The package were published from their corresponding git tag:
cordova-plugin-inappbrowser: 1.2.1 (df94a6c157)
Upon a successful vote I will upload the archives to dist/, upload them to the Plugins Registry, and post the corresponding blog post.
Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
* Run auto tests for iOS, Android and Windows
-Sergey
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: [VOTE] InAppBrowser Plugin Release
Posted by "Alexander Sorokin (Akvelon)" <v-...@microsoft.com>.
I vote +1.
* Verified signatures and hashes
* Verified tag
* Verified that plugin can be added correctly to blank app
* Verified that blank app can be successfully built and ran
* Ran smoke testing of mobilespec app
* Verified release notes
-----Original Message-----
From: Sergey Grebnov (Akvelon) [mailto:v-segreb@microsoft.com]
Sent: Tuesday, February 2, 2016 3:18 PM
To: dev@cordova.apache.org
Subject: [VOTE] InAppBrowser Plugin Release
Please review and vote on the InAppBrowser plugin release by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10505&data=01%7c01%7cv-alsoro%40microsoft.com%7c02e2cb1dd3b04708dcbb08d32bcaed28%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cG6Ib7IA9nvojJhyKguPJCOWmRQPzEHLIq%2fW3Xbl2QA%3d
The plugin has been published to dist/dev:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10505%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7c02e2cb1dd3b04708dcbb08d32bcaed28%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cPPdrfmroj3uU36AoedqJ4rV64q0wTVgtI7Zlvfia5Q%3d
The package were published from their corresponding git tag:
cordova-plugin-inappbrowser: 1.2.1 (df94a6c157)
Upon a successful vote I will upload the archives to dist/, upload them to the Plugins Registry, and post the corresponding blog post.
Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
* Run auto tests for iOS, Android and Windows
-Sergey
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org