svn commit: r399665 - /httpd/httpd/trunk/modules/filters/mod_charset_lite.c

[tr...@apache.org]

Author: trawick
Date: Thu May  4 04:18:45 2006
New Revision: 399665

URL: http://svn.apache.org/viewcvs?rev=399665&view=rev
Log:
Stop returning DECLINED from the output filter for proxy
requests.

Filters can't return that type of status.

The way to decline filter handling is to pass through the input
data unchanged and hopefully remove the output filter 
permanently.

As long as the proxy flag was set in the fixup hook, we
didn't fill in our request config and the filter will be
a no-op anyway.

Modified:
    httpd/httpd/trunk/modules/filters/mod_charset_lite.c

Modified: httpd/httpd/trunk/modules/filters/mod_charset_lite.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/modules/filters/mod_charset_lite.c?rev=399665&r1=399664&r2=399665&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/filters/mod_charset_lite.c (original)
+++ httpd/httpd/trunk/modules/filters/mod_charset_lite.c Thu May  4 04:18:45 2006
@@ -825,9 +825,6 @@
         }
     }
 
-    /* catch proxy requests */
-    if (f->r->proxyreq) return DECLINED;
-
     /* Opening the output translation (this used to be done in the fixup hook,
      * but that was too early: a subsequent type modification, e.g., by a
      * CGI script, would go unnoticed. Now we do it in the filter itself.)

Re: svn commit: r399665 - /httpd/httpd/trunk/modules/filters/mod_charset_lite.c

[Jeff Trawick <tr...@gmail.com>]

On 5/4/06, trawick@apache.org <tr...@apache.org> wrote:
> Author: trawick
> Date: Thu May  4 04:18:45 2006
> New Revision: 399665
>
> URL: http://svn.apache.org/viewcvs?rev=399665&view=rev
> Log:
> Stop returning DECLINED from the output filter for proxy
> requests.

FWIW, this is a rather obscure codepath.  mod_charset_lite won't
insert its filters automatically for proxy requests.  The user would
have to explicitly add them via one of the filter configuration
directives.