You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/09/16 09:54:06 UTC
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #652: Remove blocking
pjfanning commented on code in PR #652:
URL: https://github.com/apache/incubator-pekko/pull/652#discussion_r1327940646
##########
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyTransport.scala:
##########
@@ -525,21 +530,22 @@ class NettyTransport(val settings: NettyTransportSettings, val system: ExtendedA
// Need to do like this for binary compatibility reasons
private[pekko] def boundAddress = boundTo
+ private def extractHostAndPort(addr: Address): (String, Int) = addr match {
+ case Address(_, _, Some(host), Some(port)) => (host, port)
+ case _ => throw new IllegalArgumentException(s"Address [$addr] does not contain host or port information.")
Review Comment:
should be
```
Address [$addr] does not contain host and port information.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org