You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/21 15:36:59 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #5873: [AIRFLOW-5269] Reuse session in Scheduler Job from health endpoint

kaxil commented on a change in pull request #5873: [AIRFLOW-5269] Reuse session in Scheduler Job from health endpoint
URL: https://github.com/apache/airflow/pull/5873#discussion_r316255827
 
 

 ##########
 File path: airflow/jobs/base_job.py
 ##########
 @@ -93,7 +93,7 @@ def __init__(
 
     @classmethod
     @provide_session
-    def most_recent_job(cls, session: Session) -> Optional['BaseJob']:
+    def most_recent_job(cls, session=None) -> Optional['BaseJob']:
 
 Review comment:
   Unfortunately yes, the below line calls it without a session.
   
   https://github.com/apache/airflow/blob/aa8a30099884efbf6fd5fb276f3dc6a310866aba/airflow/www/views.py#L184

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services