You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "Venkatesh Seetharam (JIRA)" <ji...@apache.org> on 2014/08/12 00:22:13 UTC
[jira] [Commented] (FALCON-470) Add support for pagination to list
API
[ https://issues.apache.org/jira/browse/FALCON-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093443#comment-14093443 ]
Venkatesh Seetharam commented on FALCON-470:
--------------------------------------------
A lot of issues with the code and it wont compile.
FalconCLI
* lot of repetitive code, can refactor into a method
{code}
if (commandLine.getOptionValue(OFFSET_OPT) != null) {
try {
offset = Integer.parseInt(commandLine.getOptionValue(OFFSET_OPT));
} catch (NumberFormatException e) {
throw new FalconCLIException("Input value provided for queryParam \"offset\" is not a valid Integer");
}
}
{code}
* refactor this into a method
{code}
if (fields == null) {
fields = "";
} else if (!fields.equalsIgnoreCase("status")) {
throw new FalconCLIException("Invalid value for queryParam \"fields\" : "+fields);
}
{code}
* CLI is getting too unweildy, we could may be add enums and construct options from 'em, may be another jira
FalconClient
* why have you removed SUSPEND CHECKSTYLE CHECK ParameterNumberCheck
* Formatting is incorrect in ResourceList.twiki. Did you verify the generated HTML?
* You have disabled a test: org/apache/falcon/resource/EntityManagerJerseyIT.testProcessInputUpdate
* ProcessInstanceManagerIT is disabled, how did you verify?
AbstractEntityManager
* why do you have ugi as an instance variable?
{code}protected UserGroupInformation currentUgi{code}
* getEntityList is quite long, bad practice, pls refactor into methods.
filterByField init is a easy candidate
* There are 2 duplicate methods for isEntityAuthorized
AbstractInstanceManager
* method getInstanceResultSubset is too long, refactor
* I see a log of repetitive code which can be factored into the base class. pls apply DRY principle
> Add support for pagination to list API
> --------------------------------------
>
> Key: FALCON-470
> URL: https://issues.apache.org/jira/browse/FALCON-470
> Project: Falcon
> Issue Type: Sub-task
> Components: webapp
> Affects Versions: 0.6
> Reporter: Venkatesh Seetharam
> Assignee: Balu Vellanki
> Labels: rest_api
> Fix For: 0.6
>
> Attachments: Falcon-Jira-470-471-472-473-v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)