[GitHub] [calcite] asereda-gs commented on a change in pull request #1139: [CALCITE-2961] Enable Travis to test against JDK 13

[GitBox <gi...@apache.org>]

asereda-gs commented on a change in pull request #1139: [CALCITE-2961] Enable Travis to test against JDK 13
URL: https://github.com/apache/calcite/pull/1139#discussion_r270568993
 
 

 ##########
 File path: cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterTest.java
 ##########
 @@ -84,8 +86,8 @@
   private static boolean enabled() {
     final boolean enabled = CalciteSystemProperty.TEST_CASSANDRA.value();
     Bug.upgrade("remove JDK version check once current adapter supports Cassandra 4.x");
-    final boolean compatibleJdk = TestUtil.getJavaMajorVersion() != 11
-                                      && TestUtil.getJavaMajorVersion() != 12;
+    final List<Integer> incompatibleJdks = Arrays.asList(11, 12, 13);
 
 Review comment:
   Maybe it's easier to do:
   ```java
    final boolean compatibleJdk = TestUtil.getJavaMajorVersion() < 11;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services