[GitHub] [arrow] emkornfield commented on a change in pull request #10177: [Proposal] Add MONTH_DAY_NANO interval type

[GitBox <gi...@apache.org>]

emkornfield commented on a change in pull request #10177:
URL: https://github.com/apache/arrow/pull/10177#discussion_r621792072



##########
File path: format/Schema.fbs
##########
@@ -255,6 +255,10 @@ enum IntervalUnit: short { YEAR_MONTH, DAY_TIME}
 // DAY_TIME - Indicates the number of elapsed days and milliseconds,
 //   stored as 2 contiguous 32-bit integers (8-bytes in total).  Support
 //   of this IntervalUnit is not required for full arrow compatibility.
+// MONTH_DAY_NANOS - A triple of (# of months, # of days, # nanoseconds).
+//  The values are stored contiguously in 16 byte blocks. Months and
+//  days are encoded as 32 bit integers and nanoseconds is encoded as a
+//  64 bit integer.

Review comment:
       yes.  Added a sentence at the top.  I believe these all use endianness indicated by the schema.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org