You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/17 14:55:40 UTC

[GitHub] [airflow] Fokko commented on a change in pull request #5079: [AIRFLOW-4285] Update task dependency context defination and usage

Fokko commented on a change in pull request #5079: [AIRFLOW-4285] Update task dependency context defination and usage
URL: https://github.com/apache/airflow/pull/5079#discussion_r294339881
 
 

 ##########
 File path: tests/jobs/test_backfill_job.py
 ##########
 @@ -966,12 +905,11 @@ def test_backfill_max_limit_check(self):
 
         def run_backfill(cond):
             cond.acquire()
+            # this session object is different than the one in the main thread
+            thread_session = settings.Session()
 
 Review comment:
   Please use `create_session` here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services